-
Notifications
You must be signed in to change notification settings - Fork 313
Truncate large exception message when serialized #9686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Debugger benchmarksParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 6 metrics, 6 unstable metrics.
See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (325.619 µs) : 296, 356
. : milestone, 326,
basic (293.489 µs) : 288, 299
. : milestone, 293,
loop (8.97 ms) : 8964, 8975
. : milestone, 8970,
section candidate
noprobe (328.342 µs) : 269, 387
. : milestone, 328,
basic (279.377 µs) : 272, 286
. : milestone, 279,
loop (8.962 ms) : 8957, 8966
. : milestone, 8962,
|
🎯 Code Coverage 🔗 Commit SHA: e2c0ee6 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~e2c0ee62ab, baseline=1.55.0-SNAPSHOT~2aad71fc17
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.018 s) : 0, 1017551
Total [baseline] (10.661 s) : 0, 10661220
Agent [candidate] (1.025 s) : 0, 1025357
Total [candidate] (10.803 s) : 0, 10802600
section appsec
Agent [baseline] (1.198 s) : 0, 1198187
Total [baseline] (11.007 s) : 0, 11006779
Agent [candidate] (1.192 s) : 0, 1192320
Total [candidate] (11.092 s) : 0, 11092331
section iast
Agent [baseline] (1.159 s) : 0, 1158619
Total [baseline] (10.963 s) : 0, 10962770
Agent [candidate] (1.151 s) : 0, 1150954
Total [candidate] (11.021 s) : 0, 11020949
section profiling
Agent [baseline] (1.162 s) : 0, 1161847
Total [baseline] (10.988 s) : 0, 10988423
Agent [candidate] (1.169 s) : 0, 1169068
Total [candidate] (11.118 s) : 0, 11117906
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~e2c0ee62ab, baseline=1.55.0-SNAPSHOT~2aad71fc17
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.474 ms) : 0, 1474
BytebuddyAgent [baseline] (693.65 ms) : 0, 693650
BytebuddyAgent [candidate] (699.404 ms) : 0, 699404
GlobalTracer [baseline] (241.665 ms) : 0, 241665
GlobalTracer [candidate] (243.225 ms) : 0, 243225
AppSec [baseline] (32.556 ms) : 0, 32556
AppSec [candidate] (32.908 ms) : 0, 32908
Debugger [baseline] (6.399 ms) : 0, 6399
Debugger [candidate] (6.536 ms) : 0, 6536
Remote Config [baseline] (692.225 µs) : 0, 692
Remote Config [candidate] (694.313 µs) : 0, 694
Telemetry [baseline] (9.162 ms) : 0, 9162
Telemetry [candidate] (9.247 ms) : 0, 9247
Flare Poller [baseline] (10.875 ms) : 0, 10875
Flare Poller [candidate] (10.674 ms) : 0, 10674
section appsec
crashtracking [baseline] (1.48 ms) : 0, 1480
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (720.766 ms) : 0, 720766
BytebuddyAgent [candidate] (716.2 ms) : 0, 716200
GlobalTracer [baseline] (235.412 ms) : 0, 235412
GlobalTracer [candidate] (234.261 ms) : 0, 234261
AppSec [baseline] (175.314 ms) : 0, 175314
AppSec [candidate] (175.319 ms) : 0, 175319
Debugger [baseline] (6.165 ms) : 0, 6165
Debugger [candidate] (6.159 ms) : 0, 6159
Remote Config [baseline] (651.048 µs) : 0, 651
Remote Config [candidate] (650.048 µs) : 0, 650
Telemetry [baseline] (8.356 ms) : 0, 8356
Telemetry [candidate] (8.43 ms) : 0, 8430
Flare Poller [baseline] (3.91 ms) : 0, 3910
Flare Poller [candidate] (3.965 ms) : 0, 3965
IAST [baseline] (24.971 ms) : 0, 24971
IAST [candidate] (24.85 ms) : 0, 24850
section iast
crashtracking [baseline] (1.483 ms) : 0, 1483
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (820.885 ms) : 0, 820885
BytebuddyAgent [candidate] (815.025 ms) : 0, 815025
GlobalTracer [baseline] (233.399 ms) : 0, 233399
GlobalTracer [candidate] (231.773 ms) : 0, 231773
AppSec [baseline] (35.179 ms) : 0, 35179
AppSec [candidate] (35.192 ms) : 0, 35192
Debugger [baseline] (6.079 ms) : 0, 6079
Debugger [candidate] (6.148 ms) : 0, 6148
Remote Config [baseline] (620.17 µs) : 0, 620
Remote Config [candidate] (603.498 µs) : 0, 603
Telemetry [baseline] (8.497 ms) : 0, 8497
Telemetry [candidate] (8.605 ms) : 0, 8605
Flare Poller [baseline] (4.274 ms) : 0, 4274
Flare Poller [candidate] (4.188 ms) : 0, 4188
IAST [baseline] (26.882 ms) : 0, 26882
IAST [candidate] (26.653 ms) : 0, 26653
section profiling
crashtracking [baseline] (1.43 ms) : 0, 1430
crashtracking [candidate] (1.428 ms) : 0, 1428
BytebuddyAgent [baseline] (721.224 ms) : 0, 721224
BytebuddyAgent [candidate] (724.046 ms) : 0, 724046
GlobalTracer [baseline] (217.272 ms) : 0, 217272
GlobalTracer [candidate] (217.981 ms) : 0, 217981
AppSec [baseline] (32.982 ms) : 0, 32982
AppSec [candidate] (33.297 ms) : 0, 33297
Debugger [baseline] (6.466 ms) : 0, 6466
Debugger [candidate] (7.297 ms) : 0, 7297
Remote Config [baseline] (694.959 µs) : 0, 695
Remote Config [candidate] (699.408 µs) : 0, 699
Telemetry [baseline] (16.924 ms) : 0, 16924
Telemetry [candidate] (16.065 ms) : 0, 16065
Flare Poller [baseline] (4.2 ms) : 0, 4200
Flare Poller [candidate] (4.352 ms) : 0, 4352
ProfilingAgent [baseline] (107.305 ms) : 0, 107305
ProfilingAgent [candidate] (110.652 ms) : 0, 110652
Profiling [baseline] (108.892 ms) : 0, 108892
Profiling [candidate] (111.796 ms) : 0, 111796
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~e2c0ee62ab, baseline=1.55.0-SNAPSHOT~2aad71fc17
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.026 s) : 0, 1025669
Total [baseline] (8.657 s) : 0, 8656857
Agent [candidate] (1.018 s) : 0, 1017816
Total [candidate] (8.633 s) : 0, 8632724
section iast
Agent [baseline] (1.158 s) : 0, 1158482
Total [baseline] (9.276 s) : 0, 9275558
Agent [candidate] (1.154 s) : 0, 1154236
Total [candidate] (9.229 s) : 0, 9228576
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~e2c0ee62ab, baseline=1.55.0-SNAPSHOT~2aad71fc17
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.473 ms) : 0, 1473
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (699.426 ms) : 0, 699426
BytebuddyAgent [candidate] (693.553 ms) : 0, 693553
GlobalTracer [baseline] (243.1 ms) : 0, 243100
GlobalTracer [candidate] (241.833 ms) : 0, 241833
AppSec [baseline] (32.944 ms) : 0, 32944
AppSec [candidate] (32.891 ms) : 0, 32891
Debugger [baseline] (6.438 ms) : 0, 6438
Debugger [candidate] (6.425 ms) : 0, 6425
Remote Config [baseline] (698.228 µs) : 0, 698
Remote Config [candidate] (699.171 µs) : 0, 699
Telemetry [baseline] (9.241 ms) : 0, 9241
Telemetry [candidate] (9.215 ms) : 0, 9215
Flare Poller [baseline] (11.077 ms) : 0, 11077
Flare Poller [candidate] (10.681 ms) : 0, 10681
section iast
crashtracking [baseline] (1.476 ms) : 0, 1476
crashtracking [candidate] (1.467 ms) : 0, 1467
BytebuddyAgent [baseline] (821.056 ms) : 0, 821056
BytebuddyAgent [candidate] (817.128 ms) : 0, 817128
GlobalTracer [baseline] (232.905 ms) : 0, 232905
GlobalTracer [candidate] (232.657 ms) : 0, 232657
AppSec [baseline] (35.504 ms) : 0, 35504
AppSec [candidate] (35.493 ms) : 0, 35493
Debugger [baseline] (6.081 ms) : 0, 6081
Debugger [candidate] (6.117 ms) : 0, 6117
Remote Config [baseline] (599.527 µs) : 0, 600
Remote Config [candidate] (591.01 µs) : 0, 591
Telemetry [baseline] (8.517 ms) : 0, 8517
Telemetry [candidate] (8.539 ms) : 0, 8539
Flare Poller [baseline] (4.212 ms) : 0, 4212
Flare Poller [candidate] (4.192 ms) : 0, 4192
IAST [baseline] (26.887 ms) : 0, 26887
IAST [candidate] (26.683 ms) : 0, 26683
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~e2c0ee62ab, baseline=1.55.0-SNAPSHOT~2aad71fc17
dateFormat X
axisFormat %s
section baseline
no_agent (4.306 ms) : 4252, 4361
. : milestone, 4306,
iast (10.156 ms) : 9986, 10326
. : milestone, 10156,
iast_FULL (14.238 ms) : 13956, 14520
. : milestone, 14238,
iast_GLOBAL (10.793 ms) : 10604, 10983
. : milestone, 10793,
profiling (8.593 ms) : 8459, 8726
. : milestone, 8593,
tracing (7.978 ms) : 7866, 8091
. : milestone, 7978,
section candidate
no_agent (4.432 ms) : 4382, 4482
. : milestone, 4432,
iast (9.532 ms) : 9369, 9695
. : milestone, 9532,
iast_FULL (14.443 ms) : 14151, 14734
. : milestone, 14443,
iast_GLOBAL (11.255 ms) : 11043, 11467
. : milestone, 11255,
profiling (9.226 ms) : 9071, 9381
. : milestone, 9226,
tracing (7.992 ms) : 7876, 8107
. : milestone, 7992,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~e2c0ee62ab, baseline=1.55.0-SNAPSHOT~2aad71fc17
dateFormat X
axisFormat %s
section baseline
no_agent (36.332 ms) : 36038, 36627
. : milestone, 36332,
appsec (49.539 ms) : 49094, 49983
. : milestone, 49539,
code_origins (45.491 ms) : 45093, 45889
. : milestone, 45491,
iast (44.537 ms) : 44157, 44917
. : milestone, 44537,
profiling (48.017 ms) : 47573, 48460
. : milestone, 48017,
tracing (44.737 ms) : 44364, 45109
. : milestone, 44737,
section candidate
no_agent (36.601 ms) : 36314, 36889
. : milestone, 36601,
appsec (49.514 ms) : 49087, 49942
. : milestone, 49514,
code_origins (45.058 ms) : 44676, 45441
. : milestone, 45058,
iast (44.872 ms) : 44489, 45255
. : milestone, 44872,
profiling (48.626 ms) : 48177, 49075
. : milestone, 48626,
tracing (44.513 ms) : 44139, 44888
. : milestone, 44513,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~e2c0ee62ab, baseline=1.55.0-SNAPSHOT~2aad71fc17
dateFormat X
axisFormat %s
section baseline
no_agent (14.92 s) : 14920000, 14920000
. : milestone, 14920000,
appsec (14.726 s) : 14726000, 14726000
. : milestone, 14726000,
iast (18.23 s) : 18230000, 18230000
. : milestone, 18230000,
iast_GLOBAL (17.155 s) : 17155000, 17155000
. : milestone, 17155000,
profiling (14.666 s) : 14666000, 14666000
. : milestone, 14666000,
tracing (14.744 s) : 14744000, 14744000
. : milestone, 14744000,
section candidate
no_agent (15.092 s) : 15092000, 15092000
. : milestone, 15092000,
appsec (14.88 s) : 14880000, 14880000
. : milestone, 14880000,
iast (18.059 s) : 18059000, 18059000
. : milestone, 18059000,
iast_GLOBAL (17.362 s) : 17362000, 17362000
. : milestone, 17362000,
profiling (14.554 s) : 14554000, 14554000
. : milestone, 14554000,
tracing (14.62 s) : 14620000, 14620000
. : milestone, 14620000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~e2c0ee62ab, baseline=1.55.0-SNAPSHOT~2aad71fc17
dateFormat X
axisFormat %s
section baseline
no_agent (1.487 ms) : 1475, 1499
. : milestone, 1487,
appsec (2.786 ms) : 2704, 2868
. : milestone, 2786,
iast (2.571 ms) : 2471, 2670
. : milestone, 2571,
iast_GLOBAL (2.612 ms) : 2511, 2712
. : milestone, 2612,
profiling (2.402 ms) : 2317, 2487
. : milestone, 2402,
tracing (2.369 ms) : 2288, 2451
. : milestone, 2369,
section candidate
no_agent (1.49 ms) : 1478, 1501
. : milestone, 1490,
appsec (4.166 ms) : 3917, 4416
. : milestone, 4166,
iast (2.567 ms) : 2467, 2666
. : milestone, 2567,
iast_GLOBAL (2.613 ms) : 2513, 2713
. : milestone, 2613,
profiling (2.415 ms) : 2329, 2501
. : milestone, 2415,
tracing (2.347 ms) : 2266, 2428
. : milestone, 2347,
|
if exception message is larger than 2KB we truncating it for serialization into snapshot in throwable attribute. a larger message cam lead to backend drop.
d0d6649
to
9b3701a
Compare
What Does This Do
if exception message is larger than 2KB we truncating it for serialization into snapshot in throwable attribute. a larger message cam lead to backend drop.
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any useful labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: DEBUG-4539