chore: Precommit hooks and workflow #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
gabedos
force-pushed
the
gabedos/extra-linting
branch
from
f453ca1 to
0edbe4c
Compare
gabedos
force-pushed
the
gabedos/extra-linting
branch
2 times, most recently
from
39f9b69 to
3713a72
Compare
gabedos
force-pushed
the
gabedos/extra-linting
branch
from
3713a72 to
03ea337
Compare
clamoriniere
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Creates a pre-commit configuration to run additional linting checks. Both local development and the CI use the same pre-commit hooks to verify the quality of the code.
Motivation
Adds pre-commit configuration to ease verifying the quality of committed code and maintain quality via CI.
Describe how you validated your changes
Verify the CI does not attempt to run the
make fmtpre-commit step because it requires a different set of dependencies and thus a different workflow executes that.Additional Notes
Attempted using other standard tools like
prettierbut that package is limited on the files it's able to read, parse, and evaluate it's rules on. For instance, I could not find any support inprettierto do linting on terraform"*.tf"files.