Add shared pagination utility for databases #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,75 @@ | |||
| import { TableQueryOptions, TableFilter, QueryResult } from '../database/interface' | |||
|
|
|||
| export interface DatabaseAdapter { | |||
There was a problem hiding this comment.
do we need this? If yes, can we add this near BaseDatabaseManager as interface IBaseDatabaseManager?
There was a problem hiding this comment.
yes, we need it - it defines the contract for the pagination utility to work with different database implementations. I would keep it here rather than near BaseDatabaseManager since it's pagination-specific.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created a shared pagination utility to eliminate code duplication across database files in datapup. Previously, multiple database files contained identical pagination logic, leading to redundant code. This refactoring centralizes the pagination functionality into a reusable utility that can be imported and used across different database implementations.
Type of Change
Please mark the relevant option(s):
✨ New feature (non-breaking change which adds functionality)
♻️ Code refactoring
Related Issues
Fixes #99
Testing
Please confirm the following:
I have tested these changes locally
Additional Notes
The new pagination.ts utility maintains the same interface and behavior as the previous inline implementations
No breaking changes - all existing pagination functionality should work exactly as before