Skip to content

Final Polishing core.py #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 62 commits into
base: develop
Choose a base branch
from
Open

Final Polishing core.py #396

wants to merge 62 commits into from
+1,569 −687

Conversation

giovannivolpe
Copy link
Member

No description provided.

@giovannivolpe
Copy link
Member Author

This will also address issue #371

@giovannivolpe giovannivolpe linked an issue Aug 1, 2025 that may be closed by this pull request
Add new() to Feature #371
Open
Pwhsky
Pwhsky reviewed Aug 2, 2025
View reviewed changes
mirjagranfors
mirjagranfors approved these changes Aug 6, 2025
View reviewed changes
Copy link
Collaborator

@mirjagranfors mirjagranfors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good! I left a few comments on things that could be made even clearer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirjagranfors mirjagranfors mirjagranfors approved these changes

@Pwhsky Pwhsky Pwhsky approved these changes

@cmanzo cmanzo Awaiting requested review from cmanzo

@JChonpca JChonpca Awaiting requested review from JChonpca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new() to Feature
3 participants
@giovannivolpe @mirjagranfors @Pwhsky