Skip to content

Bump django-multiselectfield from 0.1.13 to 1.0.1 #12601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 13, 2025

Bumps django-multiselectfield from 0.1.13 to 1.0.1.

Release notes

Sourced from django-multiselectfield's releases.

v1.0.1

  • Badge image worked on GitHub but was broken on PyPI — fixed it.

v1.0.0

This release introduces multiple changes that are incompatible with previous versions.

The major version number has been incremented following Semantic Versioning (SemVer) <https://semver.org/>_, as several components of the package have changed in ways that may require updates in client code.

The internal codebase has been significantly cleaned up and reorganized, making it more maintainable and consistent.

This version contains 40% fewer lines of code compared to the previous release.

Less code means fewer bugs, easier maintenance, and better long-term sustainability.

  • Breaking changes

    • Remove MSFList (01dcad230dc368b88a39bfc36f90ddd145f381a2):

      • Removed: (50d3f785883e0a314f2dc89950e3fe1e88a7ede6)
      • It was created to support MultiSelectFields in admin.list_display, but it never actually worked. If you add a multiselect field to list_display, Django does not call to str method of MSGList (renamed to MSFList)
      • It was created for integer choices too and it is a misconception. This is explained in the README file.
    • Remove MSFFlatchoices (01dcad230dc368b88a39bfc36f90ddd145f381a2):

    • In to_python method, value is a list or a string. (c4579138dda2833cbce26afbf57da5353aa45690)

      • Remove set case and dict case
      • If this breaks something, please create a test to help understand the use case.
    • Removing integer choices:

      • It was a mistake. MultiSelectField inherits of CharField, not IntegerField.
      • It is impossible knows if original choice is (1, 'Item title 2.1') or ('1', 'Item title 2.1')
  • Fix: Form instance generated twice since Django (#168)

  • Fix CSS admin:

  • Fix Properly Display Categorized Choices in get_FOO_display (#169)

  • SortMultiSelectField: (#172)

... (truncated)

Changelog

Sourced from django-multiselectfield's changelog.

1.0.1 (2025-06-12)

  • Badge image worked on GitHub but was broken on PyPI — fixed it.

1.0.0 (2025-06-12)

This release introduces multiple changes that are incompatible with previous versions.

The major version number has been incremented following Semantic Versioning (SemVer) <https://semver.org/>_, as several components of the package have changed in ways that may require updates in client code.

The internal codebase has been significantly cleaned up and reorganized, making it more maintainable and consistent.

This version contains 40% fewer lines of code compared to the previous release.

Less code means fewer bugs, easier maintenance, and better long-term sustainability.

  • Breaking changes

    • Remove MSFList (01dcad230dc368b88a39bfc36f90ddd145f381a2 <https://github.com/goinnn/django-multiselectfield/commit/01dcad230dc368b88a39bfc36f90ddd145f381a2>_):

      • Removed: (50d3f785883e0a314f2dc89950e3fe1e88a7ede6 <https://github.com/goinnn/django-multiselectfield/commit/50d3f785883e0a314f2dc89950e3fe1e88a7ede6>_)
      • It was created to support MultiSelectFields in admin.list_display, but it never actually worked. If you add a multiselect field to list_display, Django does not call to str method of MSGList (renamed to MSFList)
      • It was created for integer choices too and it is a misconception. This is explained in the README file.
    • Remove MSFFlatchoices (01dcad230dc368b88a39bfc36f90ddd145f381a2 <https://github.com/goinnn/django-multiselectfield/commit/01dcad230dc368b88a39bfc36f90ddd145f381a2>_):

      • Removed: (5638247c1d70670d4f81adf35143ef17a7d7575e <https://github.com/goinnn/django-multiselectfield/commit/5638247c1d70670d4f81adf35143ef17a7d7575e>_)
      • In list_display, labels for the choices are now shown (comma-separated) instead of the values of the choices (comma-separated).
    • In to_python method, value is a list or a string. (c4579138dda2833cbce26afbf57da5353aa45690 <https://github.com/goinnn/django-multiselectfield/commit/c4579138dda2833cbce26afbf57da5353aa45690>_)

      • Remove set case and dict case
      • If this breaks something, please create a test to help understand the use case.
    • Removing integer choices:

      • It was a mistake. MultiSelectField inherits of CharField, not IntegerField.
      • It is impossible knows if original choice is (1, 'Item title 2.1') or ('1', 'Item title 2.1')
  • Fix: Form instance generated twice since Django ([#168](https://github.com/goinnn/django-multiselectfield/issues/168) <https://github.com/goinnn/django-multiselectfield/pull/168>_)

  • Fix CSS admin:

    • ([#173](https://github.com/goinnn/django-multiselectfield/issues/173) <https://github.com/goinnn/django-multiselectfield/pull/173>_)
    • (7711f4aa755c81d00f07ce8a6ff0fd9240061f9c <https://github.com/goinnn/django-multiselectfield/commit/7711f4aa755c81d00f07ce8a6ff0fd9240061f9c>_)

... (truncated)

Commits
  • 679bac6 Ready to new release
  • bef2514 Ready to new release
  • 9a564a3 Add image from github (pypi broken)
  • f2b3186 Fix typo error
  • 7289469 Fix another pypi error
  • f17a828 Improve readme file
  • d9e2b97 Fix error uploading to pypi
  • a387bc6 Ready to new release. The major version number has been incremented because t...
  • 4fc1369 If the choices are Proxy str (i18n) patched_display_for_field gets an error
  • 8bafbdb Add static files to package
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Jun 13, 2025
@dependabot dependabot bot requested a review from Maffooch as a code owner June 13, 2025 12:48
@dependabot dependabot bot added the python Pull requests that update Python code label Jun 13, 2025
@dependabot dependabot bot requested a review from mtesauro as a code owner June 13, 2025 12:48
Copy link

dryrunsecurity bot commented Jun 13, 2025

DryRun Security

No security concerns detected in this pull request.


All finding details can be found in the DryRun Security Dashboard.

Copy link
Contributor

@Maffooch Maffooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tags have two dropdown boxes, and the bottom box is the correct one
image

@valentijnscholten valentijnscholten force-pushed the dependabot/pip/dev/django-multiselectfield-1.0.1 branch from f1eda9f to f0be8ac Compare July 16, 2025 14:25
@github-actions github-actions bot added the ui label Jul 16, 2025
@valentijnscholten valentijnscholten force-pushed the dependabot/pip/dev/django-multiselectfield-1.0.1 branch from f0be8ac to e6a34a6 Compare July 16, 2025 15:32
@valentijnscholten
Copy link
Member

valentijnscholten commented Jul 16, 2025

The fields is rendered once as usual if it's empty. As soon as you put 1 tag in it, it will render twice.
I spent a lot of time figuring it out and along the way I thought I fixed it but then sometimes it occurred again.
The only way I can fix it is by removing the duplicate field after the page has loaded.
The release notes of 1.0.0 mention something about preventing duplicate fields in Django, which sounds like it could have some changes affecting our rendering.

We may have to submit an issue to the Django Tagulous repo as the people there might have a better understanding where the problem is:

  • Is django-muliselect-field@1.0.1 doing something wrong?
  • Is django-tagulous not yet compatible with django-muliselect-field@1.0.1?
  • Is the jquery select2 v4 bundled with django-tagulous not yet compatible with django-muliselect-field@1.0.1?
  • Are we doing something wrong in rendering/initializing the tag fields?

@mtesauro
Copy link
Contributor

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 20, 2025

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@mtesauro
Copy link
Contributor

@dependabot recreate

dependabot bot and others added 3 commits August 4, 2025 21:45
Bumps [django-multiselectfield](https://github.com/goinnn/django-multiselectfield) from 0.1.13 to 1.0.1.
- [Release notes](https://github.com/goinnn/django-multiselectfield/releases)
- [Changelog](https://github.com/goinnn/django-multiselectfield/blob/master/CHANGES.rst)
- [Commits](goinnn/django-multiselectfield@v0.1.13...v1.0.1)

---
updated-dependencies:
- dependency-name: django-multiselectfield
  dependency-version: 1.0.1
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@valentijnscholten valentijnscholten force-pushed the dependabot/pip/dev/django-multiselectfield-1.0.1 branch from 77fdb45 to 5624798 Compare August 4, 2025 19:45
@github-actions github-actions bot added the ui label Aug 4, 2025
@valentijnscholten
Copy link
Member

force pushed as someone overwrite my changes :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants