Implement PrintReport for Prometheus Telemetry Sink #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aasifkhan7
commented
Mar 6, 2025
aasifkhan7
commented
- Added PrintReport implementation for Prometheus sink
- Added metrics calculation for latency and error counts
- Matches output format with Memory sink for consistency
- Added PrintReport implementation for Prometheus sink - Added metrics calculation for latency and error counts - Matches output format with Memory sink for consistency
|
@aasifkhan7 don't you need to query the prometheus to get the numbers? I see all local calculations here. |
- Replace local state calculations with direct Prometheus API queries - Add proper error handling for Prometheus queries - Use histogram_quantile for percentile calculations - Add 5-minute rate window for histogram metrics - Maintain same output format for compatibility This change improves accuracy of metrics by using Prometheus' native query capabilities instead of calculating from local state.
|
@arpitbbhayani my bad, I've now made the necessary changes to query Prometheus for the numbers. Please let me know if I'm missing something else here as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.