Skip to content

build: run all misc jobs at once in nox and ci #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 22, 2025
+6 −9
Merged

build: run all misc jobs at once in nox and ci #1456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
db24a6e
build: run all misc jobs at once in nox and ci
onerandomusername Oct 20, 2025
d628d11
Rename build step to list built files
onerandomusername Oct 22, 2025
187486c
Update .github/workflows/lint-test.yml
onerandomusername Oct 22, 2025
08e6a71
Update .github/workflows/lint-test.yml
onerandomusername Oct 22, 2025
a89afac
Merge branch 'master' into qt/misc-nox
shiftinv Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions .github/workflows/lint-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,15 +251,12 @@ jobs:
with:
python-version: ${{ needs.python-versions.outputs.min-python }}

- name: Run slotscheck
if: (success() || failure()) && steps.setup.outcome == 'success'
- name: Run misc checks
run: |
nox -s slotscheck
nox --tags misc

- name: Try building package
if: (success() || failure()) && steps.setup.outcome == 'success'
- name: List built files
run: |
nox -s build
ls -la dist/

- name: Check README.md renders properly on PyPI
Expand Down
6 changes: 3 additions & 3 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,21 +250,21 @@ def lint(session: nox.Session) -> None:
session.run("prek", "run", "--all-files", *session.posargs)


@nox.session(name="check-manifest")
@nox.session(name="check-manifest", tags=["misc"])
def check_manifest(session: nox.Session) -> None:
"""Run check-manifest."""
install_deps(session)
session.run("check-manifest", "-v")


@nox.session(python=get_version_for_session("slotscheck"))
@nox.session(python=get_version_for_session("slotscheck"), tags=["misc"])
def slotscheck(session: nox.Session) -> None:
"""Run slotscheck."""
install_deps(session)
session.run("python", "-m", "slotscheck", "--verbose", "-m", "disnake")


@nox.session(requires=["check-manifest"])
@nox.session(requires=["check-manifest"], tags=["misc"])
def build(session: nox.Session) -> None:
"""Build a dist."""
install_deps(session)
Expand Down