Skip to content

Update dealadmin.py, add check for some errors #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update dealadmin.py, add check for some errors #288

wants to merge 1 commit into from

Conversation

MiceDuck
Copy link

@MiceDuck MiceDuck commented Sep 9, 2025

Add code checks for errors, refer to Error when add new deal #284

@DjangoCRM
Copy link
Owner

Hi @MiceDuck Thank you for your efforts!
Please read my comment in #284

@MiceDuck
Copy link
Author

MiceDuck commented Sep 9, 2025

Hi @MiceDuck Thank you for your efforts! Please read my comment in #284

Thanks, I see why now, I am new access to the code.
Still, it seems the check code change might be helpful, would you agree? :-)

@DjangoCRM
Copy link
Owner

Yes, in general, but in a specific case, maybe no.

@DjangoCRM DjangoCRM added the requires changes Pull requests that need to be updated based on reviewers' comments and then reviewed again label Sep 9, 2025
@MiceDuck
Copy link
Author

Yes, I agree with you.

@DjangoCRM DjangoCRM added the invalid This doesn't seem right label Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

invalid This doesn't seem right requires changes Pull requests that need to be updated based on reviewers' comments and then reviewed again

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MiceDuck @DjangoCRM