Targeting .net standard, updated .csproj format and restsharp dependency #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Using new simplified .csproj format + nuget package references - Targeting .net standard 2.0 - Updated RestSharp dependency and fixed breaking code changes
|
MB: Most of the code was generated with swagger and I didn't bother re-running the swagger stuff from scratch. I just fixed the issues and modernised the .csproj format. |
|
This PR is linked to #28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change needed?
We needed to use this library in both a project that targeted .net framework and dotnetcore.
The dependency to [restsharp had a CVE.
How does it address the issue?
The dependency is updated.
Any links to any relevant tickets, articles, or other resources?
GHSA-4rr6-2v9v-wcpc
Any screenshots?
N.A.
Did you complete all of the following?