Add Coindesk, Lunarcrush and Alternative.me services #1629
Conversation
Herklos
force-pushed
the
feature/add-new-feeds
branch
14 times, most recently
from
66b18ce to
afce280
Compare
Herklos
force-pushed
the
feature/add-new-feeds
branch
from
afce280 to
36c7484
Compare
| if abs(note) > self._EVAL_NOTIFICATION_THRESHOLD: | ||
| self.eval_note = note | ||
| self.save_evaluation_expiration_time(self._compute_notification_time_to_live(self.eval_note)) | ||
| await self.evaluation_completed(self.cryptocurrency, eval_time=self.get_current_exchange_time()) |
There was a problem hiding this comment.
I think removing this will break the evaluator
| async with aiohttp.ClientSession() as session: | ||
| while not self.should_stop: | ||
| try: | ||
| await self._push_update_and_wait(session) | ||
| except Exception as e: | ||
| self.logger.exception(e, True, f"Error when receiving Alternative.me data: ({e})") | ||
| self.should_stop = True | ||
| return False |
| market_dominance=entry["market_dominance"], | ||
| open=entry["open"], | ||
| social_dominance=entry["social_dominance"], | ||
| volume_24h=entry["volume_24h"] |
There was a problem hiding this comment.
if parsed object keys are == to dataclass keys, we could use https://github.com/Drakkar-Software/OctoBot-Commons/blob/master/octobot_commons/dataclasses/flexible_dataclass.py
(make LunarCrushCoinMetrics inherit FlexibleDataclass and use LunarCrushCoinMetrics.from_dict(entry)).
The same is true for CoindeskNews
|
|
||
| async def _start_service_feed(self): | ||
| try: | ||
| asyncio.create_task(self._update_loop()) |
There was a problem hiding this comment.
I think we should save the handle to this task and cancel it when the feed is stopped
There was a problem hiding this comment.
Right! Do you want me to also update the existing google feed that has the same code?
Herklos
force-pushed
the
feature/add-new-feeds
branch
from
36c7484 to
d5b21f4
Compare
Herklos
force-pushed
the
feature/add-new-feeds
branch
from
d5b21f4 to
dd95824
Compare
|
Thanks, it's up |
| async def stop(self): | ||
| await super().stop() | ||
| if self.listener_task is not None: | ||
| self.listener_task.cancel() |
| data = fear_and_greed_data["data"] | ||
| self.data_cache[services_constants.ALTERNATIVE_ME_TOPIC_FEAR_AND_GREED] = [ | ||
| AlternativeMeFearAndGreed( | ||
| timestamp=datetime.datetime.strptime(entry["timestamp"], '%m-%d-%Y').timestamp(), |
There was a problem hiding this comment.
this will parse dates in local time. Is it a problem? if it is, we should add replace(tzinfo=datetime.timezone.utc) (to force parsing as utc)
There was a problem hiding this comment.
Good point, I don't think it will make any difference but I'll use UTC
| data = coin_metrics_data["data"] | ||
| self.data_cache[services_constants.LUNARCRUSH_COIN_METRICS] = { | ||
| coin: [ | ||
| LunarCrushCoinMetrics.from_dict(entry) |
| async def stop(self): | ||
| await super().stop() | ||
| if self.listener_task is not None: | ||
| self.listener_task.cancel() |
Requires Drakkar-Software/OctoBot-Services#191 and Drakkar-Software/OctoBot-Evaluators#230