Transactions-related improvements #927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
List differences between transactional and non-transactional #find
…se #inspect on keys instead of #to_s
andrykonchin
force-pushed
the
ak/transaction-related-improvements
branch
3 times, most recently
from
5fc64cc to
7b160b3
Compare
… terminates the process
andrykonchin
force-pushed
the
ak/transaction-related-improvements
branch
from
7b160b3 to
9275973
Compare
… methods and raise proper exception Change methods: - #save/#save! - create/create! - #update_attributes/#update_attributes! - upsert - update_fields - #delete - #destroy/#destroy! And raise Dynamoid::Errors::MissingHashKey or Dynamoid::Errors::MissingRangeKey correspondingly. Otherwise "Aws::DynamoDB::Errors::ValidationException: Invalid attribute value type>" is raised.
andrykonchin
force-pushed
the
ak/transaction-related-improvements
branch
from
9275973 to
681e1f6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #927 +/- ##
==========================================
+ Coverage 91.92% 92.38% +0.45%
==========================================
Files 76 78 +2
Lines 3876 4042 +166
==========================================
+ Hits 3563 3734 +171
+ Misses 313 308 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrykonchin
force-pushed
the
ak/transaction-related-improvements
branch
2 times, most recently
from
b7cc569 to
7b86162
Compare
… item with specified primary key was concurrently deleted
… when an item with specified primary key was concurrently deleted
…ed primary key was concurrently deleted
… primary key was concurrently deleted
…difference between them and non-transactional ones
andrykonchin
force-pushed
the
ak/transaction-related-improvements
branch
from
7b86162 to
af7ee78
Compare
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
#findand raiseMissingHashKeywhen a given partition key isnil#save!and raiseRecordNotSavedwhen a callback throws:abortand terminates the processMissingHashKeyorMissingRangeKey)#inc,#increment!and#decrement!to not create new item when an item with specified primary key is already deleted#update_attributeto not raiseStaleObjectErrorwhen an item with specified primary key is already deleted#update/#update!to not create new item when an item with specified primary key is already deleted#where()with condition on a:serializedfield to not raise an exception