Use torch.cov instead of custom function #68
Merged
+8
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Yo, @wouterzwerink! Sorry for the really late reply. Not really that active in OSS anymore, but figured I have some time to spare. Solution looks fine. I will resolve the conflict and run some tests. Should likely apply a similar fix to all backends. |
Collaborator
|
I will merge this to development branch and test it there, as there is an issue in the main branch currently due to CI workflow issues. |
Collaborator
|
Thanks for the PR, @wouterzwerink :] It will be part of the next release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially a bit faster, results are equivalent.