Skip to content

added support for map spatial reference, base map, label properties, and lodSR #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jul 31, 2025
Merged

added support for map spatial reference, base map, label properties, and lodSR #3

merged 14 commits into from
Jul 31, 2025

Conversation

hanoch
Copy link
Member

@hanoch hanoch commented Jul 30, 2025 •
edited
Loading

added support for map spatial reference, base map, label properties, and lodSR.

Need to follow up with:

  1. Clean up the CSS styling and look and feel in general.
  2. Move and group the controls around a bit to make it logically sound.
  3. Optimize to only adjust the renderer on label changes, rather than recreate the layers (and no need to reset the map extent).

@hanoch hanoch requested a review from Jmendo12 July 30, 2025 03:46
@hanoch hanoch self-assigned this Jul 30, 2025
@hanoch hanoch requested review from qingyingwu and FrankXia July 30, 2025 04:03
Jmendo12
Jmendo12 approved these changes Jul 30, 2025
View reviewed changes
Copy link

@Jmendo12 Jmendo12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qingyingwu
qingyingwu approved these changes Jul 30, 2025
View reviewed changes
Copy link

@qingyingwu qingyingwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hanoch hanoch merged commit 9f19a1b into master Jul 31, 2025
@hanoch hanoch deleted the claude branch July 31, 2025 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingyingwu qingyingwu qingyingwu approved these changes

@Jmendo12 Jmendo12 Jmendo12 approved these changes

@FrankXia FrankXia Awaiting requested review from FrankXia

Assignees

@hanoch hanoch

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanoch @qingyingwu @Jmendo12