Skip to content

Conversation

priyansh4320
Copy link
Contributor

@priyansh4320 priyansh4320 commented Aug 1, 2025

closes #119
related issue: ag2ai/ag2#1971
Why are changes needed?
pypdf version 4.2.0 conflicts with the requirement of pypdf version in LLama-Index. Therefore, upgrade the version.

Summary by CodeRabbit

  • Chores
    • Upgraded the pypdf dependency to the 5.x series (now pinned to 5.9.0 as minimum, restricting versions below 6.0.0) in project dependency files.

Copy link

coderabbitai bot commented Aug 1, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Updated pypdf version constraints in project dependency files from the 4.x range to the 5.x range (minimum 5.9.0, upper bound <6.0.0) in both pyproject.toml and requirements.txt.

Changes

Cohort / File(s) Change Summary
Dependency version updates
pyproject.toml, requirements.txt
Raised pypdf constraint from 4.x (^4.2.0 / >=4.2.0,<5.0.0) to 5.x (^5.9.0 / >=5.9.0,<6.0.0).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Assessment against linked issues

Objective Addressed Explanation
Resolve pypdf package version conflict between llama-index, llama-index-readers-file, and graphrag-sdk (#119) Bumps pypdf to >=5.9.0,<6.0.0, matching llama-index-readers-file requirement (>=5.1.0,<6) and removing the older 4.x constraint.

Possibly related PRs

Suggested reviewers

  • galshubeli
  • swilly22

Poem

"A rabbit hops on version trails,
pypdf leaps from four to five,
Dependencies align their sails,
CI hums and tests survive.
🐇📦✨"

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between da41caa and 043708e.

⛔ Files ignored due to path filters (1)
  • poetry.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • pyproject.toml (1 hunks)
  • requirements.txt (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
pyproject.toml (1)

30-30: Consider a looser lower-bound (>=5.1) instead of pinning to 5.9

^5.9.0 forces every consumer to install at least 5.9.0.
LLama-Index requires [5.1,6), so a spec such as >=5.1,<6 (or ^5.1) would still eliminate the conflict while allowing wider compatibility and faster installs on constrained environments.

-pypdf = "^5.9.0"
+pypdf = ">=5.1,<6.0"

Not mandatory, but worth considering to avoid unnecessary over-pinning.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 191fab9 and da41caa.

⛔ Files ignored due to path filters (1)
  • poetry.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml (1 hunks)
🔇 Additional comments (1)
pyproject.toml (1)

30-30: No 4.x‐only PyPDF APIs found – upgrade to pypdf v5.x is safe

A repo-wide scan for deprecated 4.x interfaces (PdfFileReader/Writer, getPage, mergePage, addMetadata) returned zero hits. The only PDF loader import is the new PdfReader in:

  • graphrag_sdk/document_loaders/pdf.py: lines 18–36

You can keep pypdf = "^5.9.0" without pinning to 4.x.

@priyansh4320
Copy link
Contributor Author

@galshubeli, Hi, can you please review my PR?

@galshubeli
Copy link
Contributor

@galshubeli, Hi, can you please review my PR?

Thank you for the contribution and sorry it took some time

@galshubeli galshubeli merged commit 239556e into FalkorDB:main Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pypdf package version conflict between llama-index, llama-index-readers-file, and graphrag-sdk
2 participants