-
Notifications
You must be signed in to change notification settings - Fork 51
fix: upgrage pypdf version #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Caution Review failedThe pull request is closed. WalkthroughUpdated pypdf version constraints in project dependency files from the 4.x range to the 5.x range (minimum 5.9.0, upper bound <6.0.0) in both Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Assessment against linked issues
Possibly related PRs
Suggested reviewers
Poem
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pyproject.toml (1)
30-30
: Consider a looser lower-bound (>=5.1
) instead of pinning to5.9
^5.9.0
forces every consumer to install at least 5.9.0.
LLama-Index requires[5.1,6)
, so a spec such as>=5.1,<6
(or^5.1
) would still eliminate the conflict while allowing wider compatibility and faster installs on constrained environments.-pypdf = "^5.9.0" +pypdf = ">=5.1,<6.0"Not mandatory, but worth considering to avoid unnecessary over-pinning.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
poetry.lock
is excluded by!**/*.lock
📒 Files selected for processing (1)
pyproject.toml
(1 hunks)
🔇 Additional comments (1)
pyproject.toml (1)
30-30
: No 4.x‐only PyPDF APIs found – upgrade to pypdf v5.x is safeA repo-wide scan for deprecated 4.x interfaces (
PdfFileReader
/Writer
,getPage
,mergePage
,addMetadata
) returned zero hits. The only PDF loader import is the newPdfReader
in:
- graphrag_sdk/document_loaders/pdf.py: lines 18–36
You can keep
pypdf = "^5.9.0"
without pinning to 4.x.
@galshubeli, Hi, can you please review my PR? |
Thank you for the contribution and sorry it took some time |
closes #119
related issue: ag2ai/ag2#1971
Why are changes needed?
pypdf version 4.2.0 conflicts with the requirement of pypdf version in LLama-Index. Therefore, upgrade the version.
Summary by CodeRabbit