Redact JSON payloads #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ves & use ngx_flag_t for firetail_allow_undefined_routes so its usage is consistent with other boolean nginx directives
rileyfiretail
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Updates the version of the go library used & implements two directives for controlling the redaction of JSON request and response payloads.
Also cut out a bunch of code that was reimplementing functionality provided by builtin NGINX functions (
ngx_conf_set_str_slotandngx_conf_set_flag_slot).Issue ticket number and link
https://firetail-io.atlassian.net/browse/FIRE-2909
Checklist before requesting a review