Skip to content

Conversation

annajowang
Copy link
Collaborator

@annajowang annajowang commented Sep 24, 2025

This breaks e2e tests but functionality remains the same and this fixes builds on the CLI side.

Copy link

Summary of Changes

Hello @annajowang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily transitions the @apphosting/build package to use the CommonJS module system, ensuring consistent module resolution. This change is accompanied by a minor version increment for the package and an update to a key dependency, pinning it to a specific major version. The modifications aim to improve stability and compatibility within the project's module ecosystem.

Highlights

  • Module System Change: The @apphosting/build package has been explicitly configured to use the CommonJS module system by removing the "type": "module" entry from its package.json.
  • Version Bump: The version of the @apphosting/build package has been incremented from 0.1.5 to 0.1.6.
  • Dependency Update: The @npmcli/promise-spawn dependency in @apphosting/build has been updated from a wildcard * to a specific version range ^3.0.0, along with related dev flag adjustments in package-lock.json.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request converts the @apphosting/build package to a CommonJS module by removing the "type": "module" field from its package.json. While this is the main intended change, it introduces critical side effects. The project's test scripts and some source files still use ESM-specific features and import styles (like .js extensions in imports and import.meta.url), which will break in a CommonJS context. These inconsistencies need to be resolved for the package to build and test correctly.

@abhis3 abhis3 self-requested a review September 24, 2025 20:20
@annajowang annajowang merged commit e27ce11 into main Sep 24, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants