fix(pio): Replace 32-bit offset calculation with 64-bit in PIO_extend
#8697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces 32-bit arguments with 64-bit equivalents to prevent overflow when handling large files (>4GB). The original implementation incorrectly calculated offsets as 32-bit values, which made it impossible to extend the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace 32-bit arguments with 64-bit ones to prevent overflow when handling large files (>4GB).
The original implementation incorrectly calculated offsets as 32-bit values, which made it impossible to extend the file via
fallocateafter it reached 4GB in size.As I can see, every version with
PIO_extendis affected.