Skip to content

Conversation

Zaimwa9
Copy link
Contributor

@Zaimwa9 Zaimwa9 commented Sep 25, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Please describe.

How did you test this code?

Please describe.


Note

Add Tailwind CSS and Autoprefixer via PostCSS, wire into webpack, and apply initial Tailwind-based style/class updates.

  • Build/Config
    • Add tailwindcss, autoprefixer, and eslint-plugin-tailwindcss; create postcss.config.js.
    • Introduce tailwind.config.js with custom theme (colors, fonts, radii, spacing, dark mode via class, preflight disabled).
    • Update webpack to use postcss-loader for css/scss in local, prod, and Django builds.
    • Import Tailwind styles via web/styles/tailwind.css and reference in web/main.js and styles.scss.
  • Styling
    • Add Tailwind directives and CSS variables; new .tabs base styles.
    • Large portions of legacy input styles in components/_input.scss commented out.
  • UI Tweaks
    • Minor class adjustments to use utility classes (e.g., d-flexflex, add btn btn-secondary, dark:text-red-500).
    • Small content/class tweaks in FeatureAnalytics.container.tsx, Tabs.tsx, OrganisationNavbar.tsx, UsersAndPermissionsPage.tsx.

Written by Cursor Bugbot for commit 680d781. This will update automatically on new commits. Configure here.

@Zaimwa9 Zaimwa9 requested review from a team as code owners September 25, 2025 16:31
@Zaimwa9 Zaimwa9 requested review from kyle-ssg and removed request for a team September 25, 2025 16:31
@vercel
Copy link

vercel bot commented Sep 25, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview Comment Sep 30, 2025 7:20am
flagsmith-frontend-staging Ready Ready Preview Comment Sep 30, 2025 7:20am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
docs Ignored Ignored Preview Sep 30, 2025 7:20am

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-6105 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-6105 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-6105 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6105 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6105 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-6105 Finished ✅ Results

cursor[bot]

This comment was marked as outdated.

@Zaimwa9 Zaimwa9 changed the title feat: added-preflight-false feat: tailwind-poc Sep 25, 2025
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Sep 25, 2025
.flex {
@include flexbox();
@include flex-direction(column)
// @include flex-direction(column)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Flex Direction Change Breaks Vertical Layouts

Commenting out flex-direction(column) for the .flex class changes its default behavior from column to row. This breaks existing layouts across the application that depend on .flex for vertical stacking.

Fix in Cursor Fix in Web

/>
<JSONReference title={'Invite Links'} json={inviteLinks} />

<p>yolo</p>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Development Code Leaks to Production

A debug paragraph element <p>yolo</p> was accidentally committed to the Users and Permissions page, making temporary development code visible in production.

Fix in Cursor Fix in Web

p {
color: var(--text-primary) !important;
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Global Paragraph Color Override Bug

The global p { color: var(--text-primary) !important; } rule forces all paragraph text to be red in light mode (yellow in dark mode). The !important flag overrides existing styles, breaking the design system and semantic text colors across the application. This appears to be debug code.

Fix in Cursor Fix in Web

{overflow.length > 0 && !isMeasuring && (
<div
className='d-flex align-items-center justify-content-center ms-2 flex-shrink-0'
className='d-flex align-items-center justify-content-center ms-2 flex-shrink-0 btn btn-secondary'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Overflow Button Styling Conflict

Adding btn btn-secondary classes to the overflow button div conflicts with its existing inline styles (e.g., backgroundColor, borderRadius, height, width). This changes the visual appearance of the tabs overflow menu and is semantically incorrect for a div element.

Fix in Cursor Fix in Web

@@ -1,10 +1,54 @@
@tailwind base;
@import "tailwind.css";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Tailwind Base Styles Duplicated, Variables Undefined

The @tailwind base directive is included twice: once directly and again via the tailwind.css import. This duplicates Tailwind's base styles, increasing bundle size and potentially causing CSS specificity issues. Additionally, these Tailwind imports occur before the variables file, meaning custom SCSS variables are not defined when Tailwind's base styles are processed.

Fix in Cursor Fix in Web

}}
>
<span>{name}</span>
<span className='dark:text-red-500'>{name}</span>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Red Feature Names in Dark Mode

The dark:text-red-500 class was accidentally committed, causing feature names to appear red in dark mode. This appears to be test code from the Tailwind POC and is not intended for production.

Fix in Cursor Fix in Web


// Text colors
text: {
DEFAULT: '#FF0000',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Red Text Bug in Tailwind Config

The default text color in tailwind.config.js is set to #FF0000 (red), which appears to be debug code. This makes all default text red across the application, breaking the visual design.

Fix in Cursor Fix in Web

@kyle-ssg kyle-ssg marked this pull request as draft September 30, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant