fix: Do not hide navbar when in fullscreen for macOS #1988
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
please merge this asap, the issue is also applying to full screen with vertical tabs |
|
Please merge this with the main branch and push an update asap! |
|
please merge this asap, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of version 12.2.0, Floorp hides the navbar when in full-screen view (i.e. when F11 is pressed). This behavior also applies to macOS, although macOS' fullscreen view is usually more comparable to the maximized view on Windows and Linux in terms of how it's used.
For example, on Firefox:
I believe Floorp should also follow this behavior, so I've added a condition to the CSS rule so that the navbar only hides itself when it is on fullscreen on a non-macOS system.