Skip to content

(see Description) #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2025
Merged

Conversation

ygoldfeld
Copy link
Contributor

  • Pulling in submodules:
    • flow:
      • flow::log::Logger::this_thread_set_logged_nickname(), used also by various oft-used facilities including much of flow.async, now truncates the Linux-specific thread name from the back instead of from the front. (It was thought the latter technique would help disambiguate things better, when the 15-char limit was exceeded, but the opposite has become apparent over time.)
      • flow::log::Async_file_logger background log-writing thread was nicknamed something beyond Linux thread name length limit which had to be truncated; now will be, e.g., "ASFL-0x34567890" which should fit.
      • Added flow::async::reset_thread_pinning() and reset_this_thread_pinning() free function APIs which reset the core-affinity of the given -- or calling -- thread to the default state of having no preference for any particular core(s), leaving the migration decisions to the OS. This may be helpful for, e.g., background workers spawned by libraries (such as flow.log) that would otherwise inherit whatever core-affinity that may be configured for the thread of the lib user.
      • Using flow::async::reset_this_thread_pinning() at the start of the flow::log::Async_file_logger worker thread which should remain as independent and responsive as possible.
    • ipc_core, ipc_ts, isal, ipc_session:
      • Comment and/or doc changes.
      • Renaming various internal-use threads to be shorter and ideally with the more useful information up-front, in case the Linux cut-off limit truncates.
      • Using flow::async::reset_this_thread_pinning() at the start of various worker threads which should remain as independent and as responsive as possible.

related to Flow-IPC/flow#108, Flow-IPC/flow#71, #85

To code reviewer

Forgoing code review, because already reviewed elsewhere (@code-walkers).

…nt and/or doc changes. / Renaming various internal-use threads to be shorter and ideally with the more useful information up-front, in case the Linux cut-off limit truncates. / Using `flow::async::reset_this_thread_pinning()` at the start of various worker threads which should remain as independent and as responsive as possible.>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant