Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flow::log::Logger::this_thread_set_logged_nickname()
, used also by various oft-used facilities including much of flow.async, now truncates the Linux-specific thread name from the back instead of from the front. (It was thought the latter technique would help disambiguate things better, when the 15-char limit was exceeded, but the opposite has become apparent over time.)flow::log::Async_file_logger
background log-writing thread was nicknamed something beyond Linux thread name length limit which had to be truncated; now will be, e.g., "ASFL-0x34567890" which should fit.flow::async::reset_thread_pinning()
andreset_this_thread_pinning()
free function APIs which reset the core-affinity of the given -- or calling -- thread to the default state of having no preference for any particular core(s), leaving the migration decisions to the OS. This may be helpful for, e.g., background workers spawned by libraries (such as flow.log) that would otherwise inherit whatever core-affinity that may be configured for the thread of the lib user.flow::async::reset_this_thread_pinning()
at the start of theflow::log::Async_file_logger
worker thread which should remain as independent and responsive as possible.related to Flow-IPC/flow#108, Flow-IPC/flow#71, #85
To code reviewer
Forgoing code review, because already reviewed elsewhere (@code-walkers).