Skip to content

Conversation

jjw24
Copy link
Member

@jjw24 jjw24 commented Sep 27, 2021

This stems from the 1.8.3 release which failed with the latest winget-create version. Simplest fix is just to fix the version we are using since our release is a simple straight forward update.

@jjw24 jjw24 added the bug Something isn't working label Sep 27, 2021
@jjw24 jjw24 added this to the 1.9.0 milestone Sep 27, 2021
@jjw24 jjw24 self-assigned this Sep 27, 2021
@jjw24 jjw24 enabled auto-merge September 27, 2021 12:33
@taooceros
Copy link
Member

What has the latest winget changed lead to the failure?

@jjw24
Copy link
Member Author

jjw24 commented Sep 27, 2021

image

@Zeroto521
Copy link
Member

My suggestion is to keep two winget versions.
One is a stable version for now to build, and another is the latest version for the future.
If the latest version building result has any error, that could warn us.

@jjw24
Copy link
Member Author

jjw24 commented Sep 28, 2021

There is no build involved, error comes from submission via their api. Our release is not that complicated as we only update our installer in the winget pkg repo.

I agree there should be a better way to inform of the submission failure because I only picked it up in the last release when I actively checked if the submission went through to winget. Maybe appveyor or GitHub has a way to watch pipeline failures via email,I know GitHub workflow does which is really neat.

@jjw24
Copy link
Member Author

jjw24 commented Oct 9, 2021

@taooceros unless there is alternative, lets get this in.

@taooceros
Copy link
Member

OK, but I am still wondering why we cannot use the latest winget cli.

@jjw24
Copy link
Member Author

jjw24 commented Nov 2, 2021

@taooceros merge in? if 1.9.0 release still unable to do the update, i can spend time to take another look.

@taooceros
Copy link
Member

@taooceros merge in? if 1.9.0 release still unable to do the update, i can spend time to take another look.

ok

@jjw24 jjw24 merged commit 6ad49c5 into dev Nov 2, 2021
@jjw24 jjw24 deleted the fix_winget_update branch November 2, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants