Skip to content

Split Custom Control Template / Change Toggle Control Template #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Nov 11, 2021
Merged

Split Custom Control Template / Change Toggle Control Template #793

merged 17 commits into from
Nov 11, 2021

Conversation

onesounds
Copy link
Contributor

@onesounds onesounds commented Nov 7, 2021 •
edited
Loading

  • Split Custom Expander Control code to CustomControl.xaml to resource folder from app.xaml
    • It was separated to make code management easier.
  • Change Toggle Switch Style (Before: left switch, right label, / After : left label, right switch)
    • The shape of the control was changed to match the fluent style.
    • ComboBox, CheckBox, TextBox
  • Fix wrong grid and size in some setting items

Before
image

After
image

@onesounds onesounds added the kind/ui related to UI, icons, themes, etc label Nov 7, 2021
@onesounds onesounds self-assigned this Nov 7, 2021
jjw24
jjw24 reviewed Nov 10, 2021
View reviewed changes
jjw24
jjw24 reviewed Nov 10, 2021
View reviewed changes
jjw24
jjw24 reviewed Nov 10, 2021
View reviewed changes
jjw24
jjw24 reviewed Nov 10, 2021
View reviewed changes
@jjw24 jjw24 added the enhancement New feature or request label Nov 10, 2021
@jjw24 jjw24 added this to the 1.9.0 milestone Nov 10, 2021
@jjw24
Copy link
Member

jjw24 commented Nov 10, 2021

i reverted changes to the sln file

@jjw24 jjw24 enabled auto-merge November 10, 2021 21:18
@onesounds
Copy link
Contributor Author

i reverted changes to the sln file

I'm sorry. I knew that sln had changed, but I forgot to modify it.

@jjw24
Copy link
Member

jjw24 commented Nov 10, 2021

no stress, all good

@jjw24 jjw24 merged commit 362aa49 into Flow-Launcher:dev Nov 11, 2021
@jjw24 jjw24 mentioned this pull request Dec 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjw24 jjw24 jjw24 approved these changes

Assignees

@onesounds onesounds

Labels
enhancement New feature or request kind/ui related to UI, icons, themes, etc
Projects
No open projects
WIP
Status: Done
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@onesounds @jjw24