[xExtension-YouTube] add player autosize feature #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frenzie
reviewed
Feb 8, 2025
|
Any comment @kevinpapst ? |
kevinpapst
reviewed
Feb 20, 2025
| { | ||
| $content = ''; | ||
|
|
||
| if ($this->autoSize) { |
There was a problem hiding this comment.
You removed the class youtube-plugin-video. Can you re-add it, to not break existing customizations?
kevinpapst
reviewed
Feb 20, 2025
| if ($this->autoSize) { | ||
| $iframe_attribute = 'class="yt_player_autosize"'; | ||
| } else { | ||
| $iframe_attribute = 'width="' . $this->width . '" height="' . $this->height . '"'; |
There was a problem hiding this comment.
I can't remember why the style attribute was used, but I am almost certain, that I added it on purpose.
It's gone now.
kevinpapst
reviewed
Feb 20, 2025
|
|
||
| return array( | ||
| 'yt_videos' => array( | ||
| 'autosize' => 'Autogröße des Players', |
There was a problem hiding this comment.
Suggested change
| 'autosize' => 'Autogröße des Players', | |
| 'autosize' => 'Automatische Größe des Players', |
kevinpapst
requested changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I implemented this functionality that allows the youtube iframe's size to be automatically determined.
Hopefully others can enjoy this functionality as well.
Best regards