-
Notifications
You must be signed in to change notification settings - Fork 290
feat: support message delivered and message sent statuses separately #2837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MartinCupela
wants to merge
2
commits into
master
Choose a base branch
from
feat/channel-delivery-state
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -330 kB (-28.27%) 🎉 Total Size: 837 kB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Have the following message status distinctions in the message list:
sending
sent
delivered
read
Have the following message status distinctions in the channel preview:
sent
delivered
read
The
sending
status will be supported in theChannelPreview
once there is reactive state forChannel
instance.🛠 Implementation details
deliveredTo
property toMessageContext
(along already existingreadBy
). It is an array ofUserResponse
objects representing users that have confirmed the delivery or have read the messagereadBy
anddeliveredTo
MessageContext
properties are now extracted fromchannel.ownMessageReceiptsTracker
which retrieves the relevant items using binary search instead of the previous iteration over all the read objects X all the messages.Depends on
🎨 UI Changes
Sent message status (single tick) - NEW:
Delivered message status (double tick) - CHANGED ACCORDING TO DESIGNS
Todo