Add a view factory method to customise footer in VideoPlayerView #871
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
🎯 Goal
Enable
VideoPlayerView
footer customisation (e.g. adddownload video
feature).📝 Summary
ViewFactory.makeVideoPlayerFooterView()
was implemented.🛠 Implementation
The default footer implementation has been migrated to
VideoPlayerFooterView
.🎨 Showcase
🧪 Manual Testing Notes
☑️ Contributor Checklist
docs-content
repo🙋♂️To discuss
What do you think about making
ShareButtonView
public
to add ability to reuse it in a custom footer?