Skip to content

Add a view factory method to customise footer in VideoPlayerView #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

schornon
Copy link
Contributor

@schornon schornon commented Jul 2, 2025

🔗 Issue Links

🎯 Goal

Enable VideoPlayerView footer customisation (e.g. add download video feature).

📝 Summary

ViewFactory.makeVideoPlayerFooterView() was implemented.

🛠 Implementation

The default footer implementation has been migrated to VideoPlayerFooterView.

🎨 Showcase

🧪 Manual Testing Notes

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Documentation has been updated in the docs-content repo

🙋‍♂️To discuss

What do you think about making ShareButtonView public to add ability to reuse it in a custom footer?

@schornon schornon requested a review from a team as a code owner July 2, 2025 12:52
@nuno-vieira
Copy link
Member

Hi @schornon !

Thank you for your contribution!

We will add the missing changelog and run the tests ourselves.

Best,
Nuno

@schornon
Copy link
Contributor Author

Hi @nuno-vieira
Glad to hear that!

🙋‍♂️To discuss
What do you think about making ShareButtonView public to add ability to reuse it in a custom footer?


What do you think about this idea?

@nuno-vieira
Copy link
Member

Hi @nuno-vieira Glad to hear that!

🙋‍♂️To discuss
What do you think about making ShareButtonView public to add ability to reuse it in a custom footer?

What do you think about this idea?

Since this is quite a simple view, which can be easily copied, the team decided that, at the moment, it does not make sense to make it public. So for now, feel free to copy it into your codebase if you need to 👍

@nuno-vieira nuno-vieira changed the base branch from develop to add/video-player-footer-view-factory July 10, 2025 13:09
Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@nuno-vieira nuno-vieira merged commit c5440b2 into GetStream:add/video-player-footer-view-factory Jul 10, 2025
5 of 9 checks passed
nuno-vieira added a commit that referenced this pull request Jul 10, 2025
…footer (#879)

* Add a view factory method to customise the footer in VideoPlayerView (#871)

* Update CHANGELOG.md

---------

Co-authored-by: schornon <45765579+schornon@users.noreply.github.com>
@laevandus
Copy link
Contributor

Hi @schornon, we just released 4.82.0 with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants