Migrate `Feed` to consuming and firing state update events #92

gpunto · 2025-10-03T08:17:08Z

Goal

Exact same story as #91, but for Feed. This concludes the migration from WSEvent to StateUpdateEvent, so now every "controller" object (Activity, ActivityList, etc) should be updating automatically even if we are not receiving socket events.

Implementation

Change handler from WSEvent to StateUpdateEvent
Fire events from FeedImpl instead of updating the state directly

Before	Now
`_state.onFeedUpdated(feed)`	`subscriptionManager.onEvent(FeedUpdated(feed))`

I also realized that for some operations that should result in a state update, FeedImpl was not updating the state (e.g. updateBookmark), so updated those also to fire events

Testing

Similar instructions as #91, but this time even the feed should be updating. E.g. disable listening to the socket, test doing operations in the sample like adding a comment, voting on a poll, etc, and everything should be updating accordingly.

Checklist

Issue linked (if any)
Tests/docs updated
I have signed the Stream CLA (required for external contributors)

github-actions · 2025-10-03T08:17:20Z

PR checklist ✅

All required conditions are satisfied:

Title length is OK (or ignored by label).
At least one pr: label exists.
Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

Copilot

Pull Request Overview

Migrates the Feed component from consuming WebSocket events to consuming and firing state update events. This continues the architectural change started in #91, bringing Feed in line with other controller objects like Activity and ActivityList for consistent state management.

Updated Feed event handling to use StateUpdateEvent instead of WSEvent
Changed FeedImpl to fire events through subscription manager instead of updating state directly
Added feed parameter to comment events and updated existing activity deletion events for consistency

Reviewed Changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
stream-feeds-android-client/src/main/kotlin/io/getstream/feeds/android/client/internal/state/event/handler/FeedEventHandler.kt	Updated to handle StateUpdateEvent instead of WSEvent with simplified feed matching logic
stream-feeds-android-client/src/main/kotlin/io/getstream/feeds/android/client/internal/state/FeedImpl.kt	Changed to fire StateUpdateEvent through subscription manager instead of direct state updates
stream-feeds-android-client/src/main/kotlin/io/getstream/feeds/android/client/internal/state/event/StateUpdateEvent.kt	Added new event types and feed parameters to existing comment/activity events
stream-feeds-android-client/src/test/kotlin/io/getstream/feeds/android/client/internal/state/event/handler/FeedEventHandlerTest.kt	Comprehensive rewrite to test StateUpdateEvent handling with feed matching logic
Multiple test files	Updated test calls to match new event signatures with feed parameters
stream-feeds-android-client/src/main/kotlin/io/getstream/feeds/android/client/internal/repository/FeedsRepositoryImpl.kt	Updated unfollow to return FollowData instead of Unit for proper event firing

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

...s-android-client/src/test/kotlin/io/getstream/feeds/android/client/internal/test/TestData.kt

...in/kotlin/io/getstream/feeds/android/client/internal/state/event/handler/FeedEventHandler.kt

github-actions · 2025-10-03T08:20:55Z

SDK Size Comparison 📏

SDK	Before	After	Difference	Status
stream-feeds-android-client	2.47 MB	2.48 MB	0.00 MB	🟢

Copilot

Pull Request Overview

Copilot reviewed 22 out of 22 changed files in this pull request and generated no new comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot

Pull Request Overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

...t/src/main/kotlin/io/getstream/feeds/android/client/internal/state/event/StateUpdateEvent.kt

Copilot · 2025-10-03T09:31:10Z

...roid-client/src/test/kotlin/io/getstream/feeds/android/client/internal/state/FeedImplTest.kt

        val result = feed.updateFeedMembers(request)

        assertEquals(memberUpdates, result.getOrNull())
+        assertEquals(memberUpdates.updated, feed.state.members.value)


The test expects memberUpdates.updated but the mock setup has added = listOf(feedMemberData("user1")) and updated = emptyList(). This assertion should use memberUpdates.added to match the mock data.

Suggested change

assertEquals(memberUpdates.updated, feed.state.members.value)

assertEquals(memberUpdates.added, feed.state.members.value)

Thanks to this comment I realized there's an actual bug in the logic, i.e. we're never taking care of updates.added. Will fix that in a separate PR

Fixing in #93

gpunto · 2025-10-03T09:36:23Z

...kotlin/io/getstream/feeds/android/client/internal/state/event/StateUpdateEventToModelTest.kt

+import org.junit.runners.Parameterized
+
+@RunWith(Parameterized::class)
+internal class StateUpdateEventToModelTest(


I bowed to SonarCloud's request because .toModel() wasn't covered at all, but I'm not 100% convinced this test is super useful.

Copilot

Pull Request Overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

stream-feeds-android-client/src/main/kotlin/io/getstream/feeds/android/client/internal/state/event/StateUpdateEvent.kt:1

[nitpick] The import statements are not in alphabetical order. Consider sorting them alphabetically for better maintainability.

/*

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

...s-android-client/src/test/kotlin/io/getstream/feeds/android/client/internal/test/TestData.kt

...in/kotlin/io/getstream/feeds/android/client/internal/state/event/handler/FeedEventHandler.kt

VelikovPetar · 2025-10-03T13:30:32Z

...-android-client/src/main/kotlin/io/getstream/feeds/android/client/internal/state/FeedImpl.kt

    override suspend fun rejectFeedMember(): Result<FeedMemberData> {
-        return feedsRepository.rejectFeedMember(feedGroupId = group, feedId = id)
+        return feedsRepository.rejectFeedMember(feedGroupId = group, feedId = id).onSuccess {
+            subscriptionManager.onEvent(StateUpdateEvent.FeedMemberRemoved(fid.rawValue, it.id))


Quick question: Can we treat rejectFeedMember as a StateUpdateEvent.FeedMemberRemoved? Is the member in this case already a part of the feed members?

Good catch, we actually can't. It seems that in the backend this results in an update, not a removal. I'll change it accordingly.

cc @laevandus I think you have the same issue on iOS

Btw, the same seems to apply to acceptFeedMember

sonarqubecloud · 2025-10-03T14:22:51Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
91.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

gpunto added 3 commits October 3, 2025 10:08

Migrate Feed to consuming state update events

faf6411

Let Feed fire state update events instead of updating the state directly

7c067a2

Fire missing events from Feed

9220ed3

gpunto requested a review from Copilot October 3, 2025 08:17

Copilot AI reviewed Oct 3, 2025

View reviewed changes

gpunto added the pr:new-feature New feature label Oct 3, 2025

Address comments

6c047e4

gpunto requested a review from Copilot October 3, 2025 08:27

Copilot AI reviewed Oct 3, 2025

View reviewed changes

Add test for StateUpdateEvent.toModel()

e92a4b7

gpunto requested a review from Copilot October 3, 2025 09:30

Copilot AI reviewed Oct 3, 2025

View reviewed changes

gpunto commented Oct 3, 2025

View reviewed changes

Fix updateFeedMembers test

d674e19

gpunto marked this pull request as ready for review October 3, 2025 10:44

gpunto requested review from Copilot, aleksandar-apostolov and VelikovPetar October 3, 2025 10:44

Copilot AI reviewed Oct 3, 2025

View reviewed changes

...s-android-client/src/test/kotlin/io/getstream/feeds/android/client/internal/test/TestData.kt Show resolved Hide resolved

...in/kotlin/io/getstream/feeds/android/client/internal/state/event/handler/FeedEventHandler.kt Show resolved Hide resolved

VelikovPetar reviewed Oct 3, 2025

View reviewed changes

Fire FeedMemberUpdate after accepting/rejecting a member

62af361

	assertEquals(memberUpdates.updated, feed.state.members.value)
	assertEquals(memberUpdates.added, feed.state.members.value)

Migrate Feed to consuming and firing state update events #92

Are you sure you want to change the base?

Migrate Feed to consuming and firing state update events #92

Uh oh!

Conversation

gpunto commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Goal

Implementation

Testing

Checklist

Uh oh!

github-actions bot commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR checklist ✅

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SDK Size Comparison 📏

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

gpunto Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

gpunto Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

gpunto Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

VelikovPetar Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

gpunto Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gpunto Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Oct 3, 2025

Quality Gate passed

Uh oh!

Uh oh!

Migrate `Feed` to consuming and firing state update events #92

Migrate `Feed` to consuming and firing state update events #92

gpunto commented Oct 3, 2025 •

edited

Loading

github-actions bot commented Oct 3, 2025 •

edited

Loading

github-actions bot commented Oct 3, 2025 •

edited

Loading

gpunto Oct 3, 2025 •

edited

Loading

gpunto Oct 3, 2025 •

edited

Loading