[Fix]CallSettings rapid updates

[ipavlidakis]

🔗 Issue Links

Resolves https://linear.app/stream/issue/IOS-916/videoproximity-doesnt-stop-local-video-and-its-visible-on-remote

🎯 Goal

This revisions provides improvements in situations that causing CallSettings to update rapidly. With the updates, we can now ensure serial updates for those rapid changes.

🛠 Implementation

WebRTCStateAdapter now handles CallSettings updates as enqueued operations. In that way every update request will be passed the current CallSettings at the moment and is expected to return the update it needs. In this way we provide step by step updates in CallSettings rather than complete replacements.

🧪 Manual Testing Notes

• With proximity policies enabled
• Join call
• Move your hand close to the front camera
• Notice that video and speaker should be disabled
• Move your hand away from the front camera
• Video and Speaker should be reenabled
• Do that multiple times with varying speed
• When you move away from the front camera, video and speaker should always be restored

☑️ Contributor Checklist

• I have signed the Stream CLA (required)
• This change follows zero ⚠️ policy (required)
• This change should receive manual QA
• Changelog is updated with client-facing changes
• New code is covered by unit tests
• Comparison screenshots added for visual changes
• Affected documentation updated (tutorial, CMS)

[github-actions]

Public Interface

- public final class CallSettings: ObservableObject, Sendable, Equatable, ReflectiveStringConvertible  
+ public final class CallSettings: ObservableObject, Sendable, Equatable, CustomStringConvertible  
-   
+   public var description: String
- 
+   
-   public convenience init(_ response: CallSettingsResponse,file: StaticString = #file,function: StaticString = #function,line: UInt = #line)
+ 
-   public init(audioOn: Bool = true,videoOn: Bool = true,speakerOn: Bool = true,audioOutputOn: Bool = true,cameraPosition: CameraPosition = .front,file: StaticString = #file,function: StaticString = #function,line: UInt = #line)
+   public convenience init(_ response: CallSettingsResponse,file: StaticString = #file,function: StaticString = #function,line: UInt = #line)
-   
+   public init(audioOn: Bool = true,videoOn: Bool = true,speakerOn: Bool = true,audioOutputOn: Bool = true,cameraPosition: CameraPosition = .front,file: StaticString = #file,function: StaticString = #function,line: UInt = #line)
- 
+   
-   public static func ==(lhs: CallSettings,rhs: CallSettings)-> Bool
+ 
+   public static func ==(lhs: CallSettings,rhs: CallSettings)-> Bool

 public struct LogSubsystem: OptionSet, CustomStringConvertible, Sendable  
-   public var description: String
+   public static let audioRecording
-   
+   public var description: String
- 
+   
-   public init(rawValue: Int)
+ 
+   public init(rawValue: Int)

 open class StreamCallAudioRecorder: @unchecked Sendable  
-   open private lazy var metersPublisher: AnyPublisher<Float, Never>
+   @Published open private var meters: Float
-   
+   @Published open private var isRecording: Bool
- 
+   
-   public init(filename: String)
+ 
-   
+   public convenience init()
- 
+   
-   open func startRecording(ignoreActiveCall: Bool = false)async 
+ 
-   open func stopRecording()async
+   open func startRecording(ignoreActiveCall: Bool = false)
+   open func stopRecording()

[Stream-SDK-Bot]

SDK Size

title	develop	branch	diff	status
StreamVideo	8.21 MB	8.19 MB	-17 KB	🚀
StreamVideoSwiftUI	2.29 MB	2.29 MB	0 KB	🟢
StreamVideoUIKit	2.41 MB	2.41 MB	0 KB	🟢
StreamWebRTC	9.85 MB	9.85 MB	0 KB	🟢

[martinmitrevski]

why do we remove this?

[ipavlidakis]

This method was here to forward CallSettings to the publisher PeerConnection. However, because it was relying on the Combine chain for updates, it was always a time-fracture behind.

Now, we are removing this and moving the publiher peerconnection update directly on the WebRTCStateAdapter next to when it updates its own CallSettings.

[martinmitrevski]

I think I haven't seen a replacement for this? How do we listen to updates now?

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud