-
Notifications
You must be signed in to change notification settings - Fork 4k
Adjust cache life for error responses #3423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Modify caching behavior to differentiate between 404 errors and other error codes, allowing longer cache durations for 404 errors while reducing cache time for other errors.
I'm still a bit worried about the API load that this will create, we could do it on a per function basis instead of like that all at once