Skip to content

Adjust cache life for error responses #3423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 7, 2025
Merged

Conversation

conico974
Copy link
Contributor

Modify caching behavior to differentiate between 404 errors and other error codes, allowing longer cache durations for 404 errors while reducing cache time for other errors.

I'm still a bit worried about the API load that this will create, we could do it on a per function basis instead of like that all at once

Copy link

changeset-bot bot commented Jul 2, 2025

⚠️ No Changeset found

Latest commit: f89f347

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

argos-ci bot commented Jul 2, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v2 (Inspect) 👍 Changes approved 15 changed Jul 3, 2025, 9:45 AM
v2-cloudflare (Inspect) 👍 Changes approved 6 changed Jul 3, 2025, 9:50 AM
v2-vercel (Inspect) 👍 Changes approved 8 changed Jul 3, 2025, 9:48 AM

Copy link
Member

@SamyPesse SamyPesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@conico974 conico974 merged commit 377a489 into main Jul 7, 2025
16 checks passed
@conico974 conico974 deleted the gbo/better-handle-errors branch July 7, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants