-
Notifications
You must be signed in to change notification settings - Fork 4k
Implement AI actions dropdown #3431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 1a19299 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
e15764d
to
0c1d8f8
Compare
2c5f52e
to
c265320
Compare
cfd59cc
to
3d6ea49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I let @zenoachtig review, for me that's good. The "Copied" is still a bit "meh" honestly.
@gregberge Yeah, we don’t set "Copy page" as the default action if "Ask assistant" is enabled, so I can’t replace to "Copied" in the button 😕. We either need to delay the dropdown closing or use a toast cc @zenoachtig |
We should use a toast then or a tooltip popping on top of the thing saying "Copied" |
Using a programmatically opened tooltip could be an interesting one to try there. We don't really have a concept of toasts and I'd rather not introduce it for this. |
Toast are "low ui" to me, it's always better to show contextual things. Seeing coming from the button you clicked actually makes you undertand that it's the action you just did that triggered it so I think that's the best choice. |
No description provided.