Skip to content

Implement AI actions dropdown #3431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jul 8, 2025
Merged

Implement AI actions dropdown #3431

merged 22 commits into from
Jul 8, 2025

Conversation

nolannbiron
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented Jul 4, 2025

🦋 Changeset detected

Latest commit: 1a19299

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
gitbook Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

argos-ci bot commented Jul 4, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v2 (Inspect) 👍 Changes approved 144 changed Jul 8, 2025, 7:57 PM
v2-cloudflare (Inspect) 👍 Changes approved 658 changed Jul 8, 2025, 8:03 PM
v2-vercel (Inspect) 👍 Changes approved 664 changed Jul 8, 2025, 8:00 PM

@nolannbiron nolannbiron force-pushed the nolann/ai-actions-button branch from e15764d to 0c1d8f8 Compare July 4, 2025 09:12
@nolannbiron nolannbiron force-pushed the nolann/ai-actions-button branch from 2c5f52e to c265320 Compare July 4, 2025 13:30
@nolannbiron nolannbiron force-pushed the nolann/ai-actions-button branch from cfd59cc to 3d6ea49 Compare July 7, 2025 14:18
@nolannbiron nolannbiron marked this pull request as ready for review July 7, 2025 16:45
Copy link
Contributor

@gregberge gregberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I let @zenoachtig review, for me that's good. The "Copied" is still a bit "meh" honestly.

Copy link
Member Author

@gregberge Yeah, we don’t set "Copy page" as the default action if "Ask assistant" is enabled, so I can’t replace to "Copied" in the button 😕. We either need to delay the dropdown closing or use a toast

cc @zenoachtig

@gregberge
Copy link
Contributor

@gregberge Yeah, we don’t set "Copy page" as the default action if "Ask assistant" is enabled, so I can’t replace to "Copied" in the button 😕. We either need to delay the dropdown closing or use a toast

We should use a toast then or a tooltip popping on top of the thing saying "Copied"

@zenoachtig
Copy link
Contributor

@gregberge Yeah, we don’t set "Copy page" as the default action if "Ask assistant" is enabled, so I can’t replace to "Copied" in the button 😕. We either need to delay the dropdown closing or use a toast

We should use a toast then or a tooltip popping on top of the thing saying "Copied"

Using a programmatically opened tooltip could be an interesting one to try there. We don't really have a concept of toasts and I'd rather not introduce it for this.

@gregberge
Copy link
Contributor

Using a programmatically opened tooltip could be an interesting one to try there. We don't really have a concept of toasts and I'd rather not introduce it for this.

Toast are "low ui" to me, it's always better to show contextual things. Seeing coming from the button you clicked actually makes you undertand that it's the action you just did that triggered it so I think that's the best choice.

@nolannbiron nolannbiron merged commit 0003030 into main Jul 8, 2025
16 checks passed
@nolannbiron nolannbiron deleted the nolann/ai-actions-button branch July 8, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants