Skip to content

Rating columns in tables now use a solid icons instead of unfilled. #3434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 7, 2025
Merged

Rating columns in tables now use a solid icons instead of unfilled. #3434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95e4f15
Rating columns in tables now use a solid icons instead of unfilled.
emmerich Jul 4, 2025
6fa8a8b
Merge branch 'main' into stevenh/rnd-3270-get-rating-in-tables-back-t…
emmerich Jul 4, 2025
85ae8c2
Merge branch 'main' into stevenh/rnd-3270-get-rating-in-tables-back-t…
emmerich Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/gitbook/src/components/DocumentView/Table/RecordColumnValue.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {
type DocumentBlockTable,
SiteInsightsLinkPosition,
} from '@gitbook/api';
import { Icon } from '@gitbook/icons';
import { Icon, IconStyle } from '@gitbook/icons';
import assertNever from 'assert-never';

import { Checkbox } from '@/components/primitives';
Expand Down Expand Up @@ -98,6 +98,7 @@ export async function RecordColumnValue<Tag extends React.ElementType = 'div'>(
<Icon
key={i}
icon="star"
iconStyle={IconStyle.SharpSolid}
className={tcls('size-[15px]', 'text-primary')}
/>
))}
Expand Down
3 changes: 1 addition & 2 deletions packages/icons/src/Icon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@ export type IconProps = React.SVGProps<SVGSVGElement> & {
icon: IconName;

/**
* Style of the icon to render.
* @default 'solid'
* Style of the icon to render. Defaults to the current icon style from the context.
*/
iconStyle?: IconStyle;

Expand Down