Skip to content

Add autodesk.com to RWS list #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add autodesk.com to RWS list #824

wants to merge 9 commits into from
+12 −0

Conversation

JaneTang329
Copy link

@JaneTang329 JaneTang329 commented Apr 27, 2025 •
edited
Loading

Add autodesk.com to RWS list

@google-cla Google CLA
Copy link

google-cla bot commented Apr 27, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@JaneTang329
Copy link
Author

JaneTang329 commented Apr 28, 2025 •
edited
Loading

Hi RWS Team, I have 2 questions regarding this PR that I would appreciate your feedback on. Thanks!

  1. Our requirement is to add https://acc.autodesk.com and https://acc.autodesk.eu as related website sets. However, I noticed that the existing sets added by others are all top level domain(e.g., https://autodesk.com), so I used https://autodesk.com in this PR. Should I use the sub-domain(https://acc.autodesk.com) or the top-level domain(https://autodesk.com) here? Or any of them are OK?
  2. In my case, there are no associatedSites, serviceSites or rationaleBySite, only one ccTLDs set. Should I add the /.well-known/related-website-set.json for both the primary set(https://acc.autodesk.com) and the ccTLDs set(https://acc.autodesk.eu)? What content should be included in the /.well-known/related-website-set.json for the ccTLDs set(https://acc.autodesk.eu)?

@miketaylr
Copy link
Collaborator

Hey @JaneTang329,

  1. Our requirement is to add https://acc.autodesk.com/ and https://acc.autodesk.eu/ as related website sets. However, I noticed that the existing sets added by others are all top level domain(e.g., https://autodesk.com/), so I used https://autodesk.com/ in this PR. Should I use the sub-domain(https://acc.autodesk.com/) or the top-level domain(https://autodesk.com/) here? Or any of them are OK?

Using etld+1 is the correct thing to do. See the 3rd bullet point of https://github.com/GoogleChrome/related-website-sets/blob/main/RWS-Submission_Guidelines.md#set-level-technical-validation

  1. In my case, there are no associatedSites, serviceSites or rationaleBySite, only one ccTLDs set. Should I add the /.well-known/related-website-set.json for both the primary set(https://acc.autodesk.com/) and the ccTLDs set(https://acc.autodesk.eu/)? What content should be included in the /.well-known/related-website-set.json for the ccTLDs set(https://acc.autodesk.eu/)?

Note: those should be added for the etld+1/base domain -> https://autodesk.com, not the subdomain.

https://github.com/GoogleChrome/related-website-sets/blob/main/RWS-Submission_Guidelines.md#set-level-technical-validation gives an example of what that should look like.

miketaylr
miketaylr requested changes Apr 28, 2025
View reviewed changes
Copy link
Collaborator

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine (see the one suggestion), but we can't merge until the bot is happy: #824 (comment)

@GoogleChrome GoogleChrome deleted a comment from HossamMahmuod May 8, 2025
@Samuelinfantriderr46 Samuelinfantriderr46 mentioned this pull request May 10, 2025
Closed
@yasin17496
Copy link

Add autodesk.com to RWS list

@github-actions GitHub Actions
Copy link

The RWS JSON was not successfully validated. Here are your results:
Experienced an error when trying to access https://autodesk.com/.well-known/related-website-set.json; error was: HTTP Error 404: Not Found
Experienced an error when trying to access https://autodesk.eu/.well-known/related-website-set.json; error was: [Errno 104] Connection reset by peer

yasin17496
yasin17496 reviewed May 28, 2025
View reviewed changes
@GoogleChrome GoogleChrome deleted a comment from draghtnight Jun 2, 2025
@miketaylr
Copy link
Collaborator

https://autodesk.com/.well-known/related-website-set.json and https://autodesk.eu/.well-known/related-website-set.json are still 404. @JaneTang329, do you still intend to work on this?

@JaneTang329
Copy link
Author

Hi @miketaylr, Thanks for checking.
My colleagues have added these json files earlier this week.
They are accessible by below links now:

Do you this it's ok to just return the json file with www in the path? If not, can we return the file without "." as suggested below? Thanks!

Currently https://autodesk.com getting redirect to https://www.autodesk.com through our Nginx redirect.  Not only autodesk.com all the Autodesk.* parent domains. 
I think the redirect is not happening due to “.” Character.  I tried other URL the redirect is working as expected.  Is it possible to remove “.”  From https://autodesk.com/.well-known to https://autodesk.com/well-known.

@miketaylr
Copy link
Collaborator

If not, can we return the file without "." as suggested below?

No, the . is quite important. See https://datatracker.ietf.org/doc/html/rfc8615#section-3.

The better solution would be to solve the bug with your Nginx routing.

@miketaylr
Copy link
Collaborator

@JaneTang329 another question, https://www.autodesk.eu/ redirects to https://www.autodesk.com/eu- what precisely are you trying to accomplish with this set given that?

@JaneTang329
Copy link
Author

Hi @miketaylr , Thanks for the reply!
We have fixed the issue with Nginx routing, https://autodesk.com/.well-known/related-website-set.json works now. Please check.

And for why https://www.autodesk.eu/ redirects to https://www.autodesk.com/eu, I'll check and get back to you later.

@JaneTang329
Copy link
Author

Hi @miketaylr, this redirect was part of our marketing domain consolidation project. All the localized domains were consolidated to autodesk.com

@miketaylr
Copy link
Collaborator

Thanks @JaneTang329! So the question I have : if everything redirects to .com, what is the purpose of the RWS entry?

@JaneTang329
Copy link
Author

Hi @miketaylr , the thing is https://autodesk.eu redirects to https://autodesk.com/eu, but https://acc.autodesk.eu doesn't redirect. They are maintained by different teams. The actual issue is happening on https://acc.autodesk.com and https://acc.autodesk.eu.
I asked earlier that should I use https://acc.autodesk.com for the RWS list, but I was told to use https://autodesk.com and https://autodesk.eu.

@miketaylr
Copy link
Collaborator

I asked earlier that should I use https://acc.autodesk.com for the RWS list, but I was told to use https://autodesk.com and https://autodesk.eu.

Thanks for the clarification (I had indeed forgot that - and see you described it before).

But, there are a few issues that still need resolving.

  1. The set is creating a relationship between the etld+1s https://autodesk.com and https://autodesk.eu, but the related-website-set.json for autodesk.com is hosted at www.autodesk.com, due to a permanent redirect to that location.
> curl -I -A "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/137.0.0.0 Safari/537.36" https://autodesk.com/.well-known/related-website-set.json
HTTP/2 301 
date: Sat, 14 Jun 2025 15:16:44 GMT
content-type: text/html
content-length: 185
location: https://www.autodesk.com/.well-known/related-website-set.json
server: nginx/1.12.2
  1. Similarly, you also need https://autodesk.eu/.well-known/related-website-set.json to return the set. But right now it's returning a permanent redirect to the www.autodesk.eu origin:
curl -I -A "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/137.0.0.0 Safari/537.36" https://autodesk.eu/.well-known/related-website-set.json
HTTP/2 301 
content-type: text/html; charset=iso-8859-1
content-length: 272
server: Apache
serverid: dotcom-prd-web-publish04-ue1
location: https://www.autodesk.com/eu/.well-known/related-website-set.json
(rest cut for brevity)

Which then redirecting once more from www.autodesk.eu to www.autodesk.com.

> curl -I -A "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/137.0.0.0 Safari/537.36" https://www.autodesk.eu/.well-known/related-website-set.json
HTTP/2 301 
content-type: text/html; charset=iso-8859-1
content-length: 272
server: Apache
serverid: dotcom-prd-web-publish04-ue1
location: https://www.autodesk.com/eu/.well-known/related-website-set.json

@JaneTang329
Copy link
Author

Yes. That‘s the current situation. Basically, even https://acc.autodesk.com is a subdomain of https://autodesk.com, they have different redirecting rules. The same thing also apply to https://acc.autodesk.eu and https://autodesk.eu. But since I already proved we are the owner of http://autodesk.com and http://autodesk.eu, can we just pass the check?

If still not, I am afraid I can only ask to add the subdomain https://acc.autodesk.com and https://acc.autodesk.eu to the RWS list instead of etld+1s.

@miketaylr
Copy link
Collaborator

I am afraid I can only ask to add the subdomain https://acc.autodesk.com and https://acc.autodesk.eu to the RWS list instead of etld+1s.

No, apologies. The guidelines are quite clear on the technical requirements. In order to pass the checks, you'll need to fix the redirect logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yasin17496 yasin17496 yasin17496 left review comments

@miketaylr miketaylr miketaylr requested changes

@HossamMahmuod HossamMahmuod HossamMahmuod approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JaneTang329 @miketaylr @yasin17496 @HossamMahmuod @arichiv