Skip to content

feat(secretmanager): create tags sample #5337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

pragya644
Copy link

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@pragya644 pragya644 requested review from a team as code owners June 12, 2025 05:27
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jun 12, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @pragya644, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on updating the Go module dependencies for the golang-samples repository. Based on the title and the changes in the go.mod and go.sum files, the intent appears to be routine maintenance to keep the sample code's dependencies current, potentially addressing an issue or incorporating the latest library features and fixes.

Highlights

  • Dependency Updates: Updated several key dependencies in the go.mod file, including cloud.google.com/go/batch, cloud.google.com/go/bigquery, cloud.google.com/go/compute, cloud.google.com/go/storage, golang.org/x/oauth2, google.golang.org/api, and google.golang.org/protobuf, among others.
  • Module File Sync: The go.sum file was updated to reflect the new dependency versions and their checksums, ensuring module integrity.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several Go module dependencies to their newer versions. While updating dependencies is generally good for security, bug fixes, and accessing new features, it's crucial to ensure these changes don't introduce regressions or compatibility issues.

The PR description's checklist indicates several steps haven't been completed yet. Before this PR is merged, please ensure the following are addressed:

  • Run all tests: Execute go test -v ./.. and confirm they all pass. This is the most critical step to verify that the dependency updates haven't broken existing functionality.
  • Format code: Run gofmt across the codebase to ensure consistent formatting, as per the contribution guidelines.
  • Vet code: Run go vet to check for any suspicious constructs that might have been overlooked.

Completing these checks is vital for maintaining code quality and stability, especially when updating multiple dependencies.

@pragya644 pragya644 requested review from a team as code owners June 17, 2025 05:55
Copy link

snippet-bot bot commented Jun 17, 2025

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@telpirion telpirion changed the title Tags Golang Samples feat(secretmanager): create tags sample Jun 17, 2025
@telpirion telpirion self-assigned this Jun 17, 2025
@telpirion telpirion added the api: secretmanager Issues related to the Secret Manager API. label Jun 17, 2025
Copy link
Collaborator

@telpirion telpirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sample needs a test. Otherwise, this looks close to ready. Thank you!

)

// createSecretWithTags creates a new secret with the given name and labels.
func createSecretWithTags(w io.Writer, parent, id string, tagKey string, tagValue string) error {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: declare each parameter with type or declare all strings and then declare type.

The parent parameter doesn't have a type annotation, so it picks up the type from id. The remaining parameters all have individual type annotations.

Suggestion:

func createSecretWithTags(w io.Writer, parent, id, tagKey, tagValue string) error {
 // ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants