Skip to content

chore(deps): update dependency firebase-admin to v7 #13508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2025
+1 −1
Merged

chore(deps): update dependency firebase-admin to v7 #13508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion run/idp-sql/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ Flask==3.0.3
SQLAlchemy==2.0.40
pg8000==1.31.2
gunicorn==23.0.0
firebase-admin==6.6.0
firebase-admin==7.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Thanks for updating firebase-admin to a new major version. This is a good maintenance step.

After reviewing the v7.0.0 release notes and the project's code, I have two suggestions related to this upgrade:

  1. Dependency Simplification
    The pin for urllib3<2.0.0 on line 7 is likely no longer necessary. This was required because older versions of google-auth (a transitive dependency of firebase-admin) were incompatible with urllib3 v2. The updated dependencies in firebase-admin v7 resolve this. You can likely remove that line to simplify your requirements.txt.

  2. Test Environment Python Version
    firebase-admin v7 deprecates support for Python 3.9. The project's noxfile_config.py appears to run tests against Python 3.9. While this won't break the build now, it's good practice to align the test environment with the dependency's supported versions (>=3.10) to avoid future issues. This would be a good follow-up change.

The core breaking changes in v7 (like removed FCM APIs) don't seem to affect this application, so the upgrade itself looks safe.

structlog==25.1.0
urllib3<2.0.0 #https://stackoverflow.com/questions/76175361/firebase-authentication-httpresponse-object-has-no-attribute-strict-status