Fix parsing of clock status for non specified (0xFF) value #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, It is crucial to determine whether the meter has set a non-specified value. This indicates that the meter is not using the value, and its meaning differs from "OK". With your change, it will no longer be possible to write the value back to the meter because Several meters ignore the status field, and the write operation fails if the status flag differs from 0xFF. Therefore, this change cannot be accepted. BR, |
i96751414
force-pushed
the
fix-clock-statues-parsing
branch
from
5415fce to
322829a
Compare
|
Hi Mikko, Thank you for the reply. I have changed the PR according to your comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blue book states that 0xFF means non specified. As such, this should be considered as ClockStatus.OK