Lambda-ify auth server vault callbacks #1703
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A method parameter with the same name as one of the fields in the class is unpleasant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1539, part 3. This one is a bit bigger, but it makes the low-level vault code much easier to follow - so many helper structs and functions can be condensed into inline lambdas that are just a few lines long.
This intentionally only covers the low-level
NetCliAuthVaultfunctions. The high-level vault API still uses C-style function pointers for now - I'll convert that separately later, because I expect that to be a similar amount of effort.Small detail: some of the
NetCliAuthVaultfunctions acceptednullptrif the caller doesn't need a callback, but others didn't. For consistency, I made all of the callbacks required now. If a caller really doesn't need a callback, it's easy to explicitly pass an empty lambda.