Fix output image filenames in ALLEGRO ECAL simulation section #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrieucF
reviewed
Oct 9, 2025
| python plot_calo_energy_resolution.py ALLEGRO_sim_digi_reco.root | ||
| display electron_gun_10GeV_ALLEGRO_RECO_clusterEnergyResolution.png | ||
| display electron_gun_10GeV_ALLEGRO_RECO_calibratedClusterEnergyResolution.png | ||
| ALLEGRO_sim_digi_reco_clusterEnergyResolution.png |
Contributor
There was a problem hiding this comment.
Hi Reza, thanks, why did you remove the "display" part?
Author
There was a problem hiding this comment.
Hi Brieuc,
Thanks for your correction. It was a typo from my side. Sorry!
Just fixed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected the output image filenames for the ALLEGRO ECAL simulation section in FCCeeGeneralOverview.md.
The previous instructions had old filenames which do not match the generated output files:
Old: electron_gun_10GeV_ALLEGRO_RECO_clusterEnergyResolution.png
New: ALLEGRO_sim_digi_reco_clusterEnergyResolution.png
Old: electron_gun_10GeV_ALLEGRO_RECO_calibratedClusterEnergyResolution.png
New: ALLEGRO_sim_digi_reco_calibratedClusterEnergyResolution.png
This change aligns the tutorial with the actual output of the simulation.