Change game id type so it won't overflow. #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*** This PR should be left unmerged until such time when it is ready to be run on the production database. ***
This changes the game id type in the database from mediumint to int so that the field doesn't overflow after 16 million games.
Because mysql cannot alter multiple tables in one transaction, before running the alembic upgrade game updates to the database should be stopped. This is probably easiest done by either by stopping the coordinator or stopping all workers. Specifically because the on delete cascade constraints will not be enforced while the update is made any games deleted during the update will leave orphan entries in the dependent tables. This will cause the re-addition of the constraints to fail after the update completes.
If other alembic revisions are added after the creation of this PR but before it is merged the revision here will need to have its down_revision changed to the current head.