Rework FlxSound load methods

[ACrazyTown]

Closes #3466.

• Deprecates loadEmbedded(), loadStream() and loadByteArray() and replaces them with load() and loadFromURL().
• Deprecate FlxG.sound.stream() for FlxG.sound.loadFromURL() to stay consistent
• Add loadStreamed() to allow loading streamed sounds. Additionally adds required functionality to FlxG.assets
• Modifies FlxSoundAsset to allow passing in a ByteArray.

[Geokureli]

Is this something that can be unit tested? I'm genuinely not sure.

[ACrazyTown]

I'm a bit unfamiliar when it comes to unit tests. Maybe we could check if the internal sound (_sound) is created and not null to see if Flixel managed to detect the data properly. I'm not sure if we can check if the sound loaded properly though, maybe checking length?

[Geokureli]

NVM, FlxSoundTest doesn't actually test any of the existing args, so let's look into that in the future

[Geokureli]

Just gonna say it, a byte array isn't "embedded", so it's odd to use this to load it... Maybe we should add a new load() method and deprecate loadEmbedded (maybe in a later version)?

Thoughts?

[ACrazyTown]

Just gonna say it, a byte array isn't "embedded", so it's odd to use this to load it... Maybe we should add a new load() method and deprecate loadEmbedded (maybe in a later version)?

Thoughts?

Sounds good. While we're at it, I think it might be worth renaming loadStream() as well. From what I can tell the main purpose of it seems to be to load sounds from web locations, but there's a different concept of "streamed sounds" that would be nice to have built in.

Streamed sounds are helpful to use less memory when dealing with large music tracks for example. Instead of loading the entire file and playing it, they load (and unload) smaller chunks of data as they play.

We could have something like load(), loadFromURL() and loadStreamed() (but maybe that could be an argument in load() instead)

[Geokureli]

loadFromURL seems best to me

Also Openfl does have the ability to "stream" audio, but I don't know if flixel leverages this

[ACrazyTown]

Also Openfl does have the ability to "stream" audio, but I don't know if flixel leverages this

I believe it doesn't. I think we just have to use Assets.getMusic() (which internally sets up the sound to be streamed) instead of Assets.getSound()

[Geokureli]

Also Openfl does have the ability to "stream" audio, but I don't know if flixel leverages this

I believe it doesn't. I think we just have to use Assets.getMusic() (which internally sets up the sound to be streamed) instead of Assets.getSound()

I forgot how I did it, but there's a way on html5 to stream a sound from the web

[ACrazyTown]

Should I repurpose this and also include the load() changes here or should that be done in a seperate PR?

[Geokureli]

Should I repurpose this and also include the load() changes here or should that be done in a seperate PR?

Please include that change, here