40% build speedup: get torch and python include paths without subprocesses #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technillogue
force-pushed
the
no-setup-subprocess
branch
from
40899ea to
97b1e47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting python and importing torch is slow. Calling python in a subprocess could potentially be useful if the python environment changes while setup.py is running, but I don't think that can actually happen.
Timing
python3 setup.py build, before this change:real 1m1.822s
user 1m38.202s
sys 0m9.250s
real 1m2.285s
user 1m38.653s
sys 0m9.281s
After:
real 0m58.403s
user 0m58.709s
sys 0m7.626s
real 0m58.840s
user 1m19.693s
sys 0m8.612s