Fix bfcl so that instances do not explode in size, and all cards yield recipes that pass _source_to_dataset #1915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dafnapension
force-pushed
the
fix_bfcl
branch
2 times, most recently
from
ecf21ce to
e460ae3
Compare
Signed-off-by: dafnapension <dafnashein@yahoo.com>
…taset Signed-off-by: dafnapension <dafnashein@yahoo.com>
Signed-off-by: dafnapension <dafnashein@yahoo.com>
… with xlam Signed-off-by: dafnapension <dafnashein@yahoo.com>
dafnapension
force-pushed
the
fix_bfcl
branch
from
6361d56 to
e98faa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1894 and also fixes small issues that prevent the recipes generated from the bfcl cards prepared to be well processed by
_source_to_dataset(mainly schema issues)Errors before the fix:
bfcl_main.pdf
No errors after, and instance sizes are reasonable:
bfcl_fix.pdf