-
Notifications
You must be signed in to change notification settings - Fork 1
Working ContractNetwork #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
==========================================
- Coverage 34.85% 0.00% -34.86%
==========================================
Files 3 4 +1
Lines 175 195 +20
==========================================
- Hits 61 0 -61
- Misses 114 195 +81
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
for more information, see https://pre-commit.ci
@mtfishman I'm not really sure what the failing test is to do with... something coming from |
It looks like moving the TensorOperations code to a package extension made it so that ITensorBase is no longer a direct dependency of ITensorNetworksNext, since now it is only used in that package extension (Aqua is rightly detecting that situation and seeing that there is a dependency listed in the Project.toml that isn't being used in the main package). However, in this case I think we should try to use NamedDimsArrays directly rather than ITensorBase, I can give you pointers on how to do that. |
This PR introduces the ability to contract vectors of
AbstractArrays
and thusAbstractTensorNetwork
s via thecontractnetwork(tn; sequence)
function.The
sequence
is used to tell thecontraction_sequence
backend how to find the desired sequence, with the stringssequence= "leftassociative" and "optimal"
supported (the latter viaTensorOperations
) alongside support for sending a specific pre-defined sequence.Rudimentary tests are included, although we might want to consider making these more robust and also testing the sequence finding functionality ourselves.