Skip to content

ignored validation when view is invisible or gone #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ignored validation when view is invisible or gone #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion library/src/main/java/br/com/ilhasoft/support/validation/rule/Rule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,12 @@ public final boolean validate() {
} else {
onValidationFailed(view);
}
return valid;

//if view is not visible then always returns true
// so that it doesn't hamper validation success
boolean isHidden = (view.getVisibility() != View.VISIBLE);

return isHidden || valid;
}

protected abstract boolean isValid(ViewType view);
Expand Down