Skip to content

Conversation

NguyenHoangSon96
Copy link
Contributor

@NguyenHoangSon96 NguyenHoangSon96 commented Sep 9, 2025

Closes #173

Proposed Changes

  • Support passing HttpClient from outside.
  • If users pass HttpClient, they will be responsible for its states and lifecycle, but the InfluxDB client will add the authentication header and base URL automatically.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@NguyenHoangSon96 NguyenHoangSon96 added this to the 1.4.0 milestone Sep 9, 2025
@NguyenHoangSon96 NguyenHoangSon96 self-assigned this Sep 9, 2025
@NguyenHoangSon96 NguyenHoangSon96 changed the title feat: support-passing-HttpClient feat: support passing HttpClient Sep 9, 2025
Copy link

codecov bot commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.72%. Comparing base (3676b9b) to head (302c9dc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
+ Coverage   96.68%   96.72%   +0.04%     
==========================================
  Files          18       18              
  Lines        1417     1436      +19     
  Branches      188      191       +3     
==========================================
+ Hits         1370     1389      +19     
  Misses          5        5              
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@jansimonb jansimonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

@NguyenHoangSon96 NguyenHoangSon96 merged commit f95b720 into main Sep 10, 2025
10 checks passed
@NguyenHoangSon96 NguyenHoangSon96 deleted the feat/support-passing-HttpClient branch September 10, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow injecting HttpClient / HttpMessageHandler or using IHttpClientFactory instead of always creating a new HttpClient
2 participants