-
Notifications
You must be signed in to change notification settings - Fork 10
feat: simplify timeout settings #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
5643138
feat: add QueryTimeout and WriteTimeout
NguyenHoangSon96 e7c5cc0
test: add test cases
NguyenHoangSon96 986b92e
test: add test cases
NguyenHoangSon96 2345f9b
chore: dotnet format
NguyenHoangSon96 2371833
[EMPTY] trigger CI
NguyenHoangSon96 4d15fc1
test: add test cases
NguyenHoangSon96 4ff3898
chore: CHANGELOG.md
NguyenHoangSon96 c0d9e0c
fix: revert null to default
NguyenHoangSon96 21f7434
chore: dotnet format
NguyenHoangSon96 f88e28d
[EMPTY] trigger CI
NguyenHoangSon96 9182524
[EMPTY] trigger CI
NguyenHoangSon96 e811c69
test: improve WriteTest
NguyenHoangSon96 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we want to remove this test if the
ClientConfig.Timeout
property has only been deprecated and not removed. Some users may continue to use it. It's reassuring to know, even though the property is deprecated, the code section continues to work.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this test and the part where we set the Timeout directly to HttpClient object because if we set the Timeout directly to the HttpClient, it will have conflicting behavior when we also set QueryOptions.Deadline.
If we set the Timeout directly to the HttpClient and set the QueryOptions.Deadline, grpc will get the smallest timeout between them, and I don't think this is the right behavior.
The new implementation will absolutely prioritize: QueryOptions.Deadline > QueryTimeout > Timeout (If the users set the Timeout property, it will not directly set the Timeout to the HttpClient, so the QueryOptions.Deadline still runs like intended ). These are my thoughts.