Skip to content

Allow type casting of zero-sized array to any dtype #2123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

antonwolfy
Copy link
Collaborator

@antonwolfy antonwolfy commented Jul 14, 2025

This PR allows type casting zero-sized usm_ndarray to any dtype (including larger ones).

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

Copy link

Copy link

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_59 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

@coveralls
Copy link
Collaborator

coveralls commented Jul 14, 2025

Coverage Status

coverage: 85.89%. remained the same
when pulling 4947f5c on resolve-gh-2119
into e2789db on master.

Copy link

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_60 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

Copy link

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_60 ran successfully.
Passed: 1116
Failed: 5
Skipped: 119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dpctl raises ValueError when changing to larger dtype through the constructor
3 participants