New procedurally generated animations for the blocks #737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyxkad
reviewed
May 18, 2025
| @@ -1,2 +1,7 @@ | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
guh conflicts :/
can you remove the .cache folder and do runData again?
|
I noticed the highlight area changed, are they randomly generated? I personally think randomly generate stuff on this is not good, so maybe you can set a fixed seed? |
Build PreviewYou can find files attached to the below linked Workflow Run URL (Logs).
|
|
sure, i'll add an option to the script |
|
done |
|
Can you document the procedure exactly step by step here, so I and other contributors know exactly how things will work, what we would need to do when we have new textures, trying to run the data gens etc |
|
sure, done |
# Conflicts: # src/generated/resources/.cache/b8526e444ae7356037f3a813274f6835d1f3dd16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the parts of the blocks that were previously left static move, glow, shift, whatever you want to call it. The animations are generated by a tool that can be found here. It uses the old textures as the assets that it then modifies in order to build the animations, which is why the old textures are left untouched in the sources directory. This ensures that the original textures can be easily found and accessed by anyone who wishes to further improve or modify them, because applying changes to their post-processed versions can be somewhat tedious.