Skip to content

Conversation

@carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Jul 15, 2025

Changelog

- description: |
    cardano-rpc | Add UTxO RPC: submitTx method
# uncomment types applicable to the change:
  type:
   - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...
  projects:
  - cardano-rpc

Context

Tested in:

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer self-assigned this Jul 15, 2025
@carbolymer carbolymer force-pushed the mgalazyn/feature/add-utxorpc-submit branch from 676a548 to 5714f92 Compare July 15, 2025 15:48
@carbolymer carbolymer force-pushed the mgalazyn/feature/add-utxorpc-readutxos-query branch 2 times, most recently from 70a5ffd to 5a88b6b Compare July 16, 2025 09:53
@carbolymer carbolymer force-pushed the mgalazyn/feature/add-utxorpc-submit branch from 5714f92 to f61b8f0 Compare July 16, 2025 10:04
@carbolymer carbolymer force-pushed the mgalazyn/feature/add-utxorpc-readutxos-query branch from 5a88b6b to 369f3eb Compare July 16, 2025 11:48
@carbolymer carbolymer force-pushed the mgalazyn/feature/add-utxorpc-submit branch from f61b8f0 to 00826a1 Compare July 16, 2025 11:50
@carbolymer carbolymer force-pushed the mgalazyn/feature/add-utxorpc-readutxos-query branch 3 times, most recently from 6dd1314 to b2c9cea Compare July 22, 2025 13:07
Base automatically changed from mgalazyn/feature/add-utxorpc-readutxos-query to master July 22, 2025 13:27
@carbolymer carbolymer force-pushed the mgalazyn/feature/add-utxorpc-submit branch 3 times, most recently from 5b914b3 to bd6f4f9 Compare July 24, 2025 07:36
@carbolymer carbolymer marked this pull request as ready for review July 24, 2025 07:36
@carbolymer carbolymer force-pushed the mgalazyn/feature/add-utxorpc-submit branch from bd6f4f9 to db70b89 Compare July 24, 2025 07:36
@carbolymer carbolymer force-pushed the mgalazyn/feature/add-utxorpc-submit branch from db70b89 to 65166bc Compare July 24, 2025 07:37
repeated AnyChainTx tx = 1; // List of transactions to submit.
}

// TODO u5c: new type
Copy link
Contributor

@Jimbo4350 Jimbo4350 Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you implemented something that deviates?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is a new "sum type" isomorphic to Either. Original proto file had just successful txIds without errors. https://github.com/utxorpc/spec/blob/main/proto/utxorpc/v1alpha/submit/submit.proto#L38

@carbolymer carbolymer added this pull request to the merge queue Jul 24, 2025
Merged via the queue into master with commit 1563033 Jul 24, 2025
29 of 30 checks passed
@carbolymer carbolymer deleted the mgalazyn/feature/add-utxorpc-submit branch July 24, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants