Skip to content

Conversation

carlostome
Copy link
Collaborator

@carlostome carlostome commented Jul 23, 2025

Description

Cleans mdbook from the repository.

  • Moves assets from common/src to mkdocs/docs
  • Removes mdbook specific files

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Any semantic changes to the specifications are documented in CHANGELOG.md
  • Code is formatted according to CONTRIBUTING.md
  • Self-reviewed the diff

@carlostome carlostome self-assigned this Aug 22, 2025
@carlostome carlostome marked this pull request as ready for review September 25, 2025 10:52
In particular, we need to keep the js path in the build_config,
otherwise we won't have the nice colors in dark mode.

Also, I think we should either continue to have an `md/common` (and put
there everything that could be used in other web platforms) OR put
everything under `md/mkdocs/docs` (e.g., `css/custom.css` and
`js/custom.js`), but I don't think we should have an `md/common` that
only contains just *some* of the common stuff.
Copy link
Member

@williamdemeo williamdemeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the pipeline and checked the resulting web site. I fixed some things that broke (e.g., Agda colors in dark mode; a missing reference due to a bad path to ConwayBootstrap.md and ConwayBootstrapEnact.md) and rearranged it so basically all the static web stuff is under mkdocs, since it's seemed you had gone most of the way to that end. Everything seems to be working now. Nice work! LGTM

but we do need md_js_dir (for katex-config.js)
@williamdemeo williamdemeo merged commit 118f298 into master Sep 28, 2025
14 checks passed
@williamdemeo williamdemeo deleted the carlos-remove-mdbook branch September 28, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants