Advanced coupling #1014
Open
Advanced coupling #1014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spirali
force-pushed
the
advanced-coupling
branch
6 times, most recently
from
c2d3e34 to
d556f1f
Compare
spirali
force-pushed
the
advanced-coupling
branch
from
d556f1f to
c2348c2
Compare
spirali
force-pushed
the
advanced-coupling
branch
from
ddd0db4 to
a059aa0
Compare
|
I am still not sure if the price for HiGHS is worth, but if it compiles it seems to me more safe default for performance reasons. On the other hand, it is not hard to remove HiGHS in case of problems. This PR is blocking some other changes in the scheduler. So I am now asking for review request. But there is no need to hurry because of my vacation. (However it is also blocking #959.) |
Kobzol
reviewed
Oct 6, 2025
| /// - `--coupling cpus,gpus" | ||
| #[arg(long, value_parser = passthrough_parser(parse_resource_coupling))] | ||
| pub coupling: Option<PassThroughArgument<ResourceDescriptorCoupling>>, | ||
| /// - `--coupling TODO" |
| input: &str, | ||
| resources: &[ResourceDescriptorItem], | ||
| ) -> anyhow::Result<(u8, ResourceGroupIdx)> { | ||
| let input = input.trim(); |
There was a problem hiding this comment.
You gave up on the parser combinators? 😆 It's easier to have a high quality error message when parsing "manually", that's for sure...
There was a problem hiding this comment.
I am not giving up completely, but if I remember correctly, in this case, it was quite ugly code and manual parser was easy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces advance coupling that allows to set individual weights between groups.
Important notes: