Skip to content

[MOB-8113] adds placement ids array to sync messages #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

evantk91
Copy link
Collaborator

@evantk91 evantk91 commented Feb 12, 2025

🔹 Jira Ticket(s)

✏️ Description

This pull request adds optional parameter for placement ids to sync messages to make use of optional parameter on get messages API.

@evantk91 evantk91 marked this pull request as draft February 12, 2025 21:58
@evantk91 evantk91 marked this pull request as ready for review February 12, 2025 22:57
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

Attention: Patch coverage is 31.25000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 69.21%. Comparing base (6e2fdec) to head (058c5ec).
Report is 867 commits behind head on master.

Files with missing lines Patch % Lines
...k/Internal/api-client/Request/RequestCreator.swift 0.00% 7 Missing ⚠️
swift-sdk/Internal/api-client/ApiClient.swift 0.00% 3 Missing ⚠️
swift-sdk/Internal/EmptyEmbeddedManager.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #898       +/-   ##
===========================================
- Coverage   85.19%   69.21%   -15.98%     
===========================================
  Files          91      104       +13     
  Lines        6301     7559     +1258     
===========================================
- Hits         5368     5232      -136     
- Misses        933     2327     +1394     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@joaodordio joaodordio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

little changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants